[jira] [Commented] (OAK-2870) Introduce a SegmentNodeStoreBuilder to help wire a SegmentNodeStore

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547820#comment-14547820 ] 

Michael Dürig commented on OAK-2870:
------------------------------------

Patch looks good to me. Makes for a much cleaner setup! Couldn't we make {{CompactionStrategy.setRetryCount}} and {{CompactionStrategy.setForceAfterFail}} also part of the builder so we'd have everything in one place? Also calling {{create}} on the builder without a prior call to {{withCompactionStrategy}} will cause a {{NPE}} I think. We should either fall back to a good default in that case or bail out with an {{ISE}}. 

> Introduce a SegmentNodeStoreBuilder to help wire a SegmentNodeStore
> -------------------------------------------------------------------
>
>                 Key: OAK-2870
>                 URL: https://issues.apache.org/jira/browse/OAK-2870
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: OAK-2870.patch
>
>
> Exposing the SegmentNodeStore for tests outside oak-core is quite tricky as you need to access some compaction related methods which are basically private and it doesn't make much sense in making them public. 
> So I'm proposing introducing a builder to help wire in a SegmentNodeStore if needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)