You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "giacomochiarella (via GitHub)" <gi...@apache.org> on 2025/10/18 13:10:15 UTC

Re: [PR] fix(sqllab): ensure SQL_QUERY_MUTATOR is called when MUTATE_AFTER_SPLIT=True [superset]

giacomochiarella commented on code in PR #34111:
URL: https://github.com/apache/superset/pull/34111#discussion_r2442417196


##########
superset/sql_lab.py:
##########
@@ -475,7 +475,9 @@ def execute_sql_statements(  # noqa: C901
             db.session.commit()
 
             # Hook to allow environment-specific mutation (usually comments) to the SQL
-            query.executed_sql = database.mutate_sql_based_on_config(block)
+            query.executed_sql = database.mutate_sql_based_on_config(
+                block, is_split=config["MUTATE_AFTER_SPLIT"]

Review Comment:
   Looking for the same solution here. We want to use one single user database connection configured in Superset and set role before any query is executed, either from sqllab or dataset/chart/dashboard. The role needs to be determined based on the logged in user is executing the query



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org