You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by anshul1886 <gi...@git.apache.org> on 2015/12/04 07:25:20 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1164
CLOUDSTACK-8845: Fixed list snapshots command throwing exception
https://issues.apache.org/jira/browse/CLOUDSTACK-8845
Fixed list snapshots command throwing exception if any one of snapshot is not present on primary.
Bug got introduced because of KVM specific code.
Testing done
List snapashots working fine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1164
----
commit 91578903e1c687991329aac1518ca6717ac81285
Author: Anshul Gangwar <an...@citrix.com>
Date: 2015-11-23T09:26:53Z
CLOUDSTACK-8845: Fixed list snapshots command throwing exception if any one of snapshot is not present on primary
Bug got introduced because of KVM specific code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161889769
@anshul1886 Thanks for the fix! Could you please make this PR against 4.6? Once merged in 4.6, it will be fwd-merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161893553
@anshul1886 Thanks, you can close this PR as the other one will go to both 4.6 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161891307
Created PR https://github.com/apache/cloudstack/pull/1166 for 4.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/1164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---