You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@pivot.apache.org by Greg Brown <gk...@mac.com> on 2010/04/20 15:43:21 UTC
"split" style vs. "split" property
I wonder if the "split" style that was recently added to TerraListButtonSkin might be better-suited as a property of ListButton itself. That way, it implies that all list buttons must support this behavior, not just Terra list buttons.
Re: "split" style vs. "split" property
Posted by Greg Brown <gk...@mac.com>.
FYI, I have made this change. I'll check it in along with the fix for issue PIVOT-475.
On Apr 20, 2010, at 12:09 PM, Greg Brown wrote:
>> I agree. Styles control the "look", while properties control the "feel" of a component. "split" is definitely more "feel" than "look". A bad design on my part, sorry. But it was easier to simply patch this into the Skin class.
>
> OK - do you want to make this change? If not, I can do it.
>
>> Boy, if I'd known the broad ramifications of this issue beforehand, I'd kept my mouth shut. ;-)
>
> :-)
>
Re: "split" style vs. "split" property
Posted by Greg Brown <gk...@mac.com>.
> I agree. Styles control the "look", while properties control the "feel" of a component. "split" is definitely more "feel" than "look". A bad design on my part, sorry. But it was easier to simply patch this into the Skin class.
OK - do you want to make this change? If not, I can do it.
> Boy, if I'd known the broad ramifications of this issue beforehand, I'd kept my mouth shut. ;-)
:-)
Re: "split" style vs. "split" property
Posted by Dirk Möbius <dm...@scoop-gmbh.de>.
Greg Brown <gk...@mac.com> wrote:
> I wonder if the "split" style that was recently added to
> TerraListButtonSkin might be better-suited as a property of
> ListButton itself. That way, it implies that all list buttons must
> support this behavior, not just Terra list buttons.
I agree. Styles control the "look", while properties control the
"feel" of a component. "split" is definitely more "feel" than "look".
A bad design on my part, sorry. But it was easier to simply patch this
into the Skin class.
Boy, if I'd known the broad ramifications of this issue beforehand,
I'd kept my mouth shut. ;-)
Dirk.