Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-1928500048

   There'd be two main ways to approach this:
   - having different semantics around formulas and an engine that's formula-aware, meaning it could pushdown to SQL or render on the backend/frontend. This may work for ratios or averages, but not for distinct counts or percentiles
   - running multiple queries, one for each aggregation-level. This can get complex if service into sub-totals and multiple dimensions
   
   Both of those would be significant work and add much more complexity to the current SQL-oriented approach.
   
   It could be good though to hide totals for non-additive metrics though, probably through per-metric inference or configuration. If it's a simple metric, we know which aggregation methods are additive and/or why. If it's SQL expression, the user may have to tell us if it's additive or not. A simple quick-fix would be to only show the totals where people use the `SUM`-type simple metric (which is probably 80%+ of metrics out there).
   
   Interestingly, for things like average we could be smarter, and for things like ratio (ask the db for a SUM(col) and a COUNT(col)) and do our own math. For ratio we could introduce new "not-so-simple" metrics where you specify your numerator metric and denominator metric and we could compute totals properly.... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org