[GitHub] [incubator-druid] leventov commented on a change in pull request #7595: Optimize overshadowed segments computation

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7595: Optimize overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282159420
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/metadata/MetadataSegmentManager.java
 ##########
 @@ -98,6 +98,15 @@
 
   Collection<String> getAllDataSourceNames();
 
+  /**
+   * Returns a collection of overshadowed segments
+   *
+   * Will return null if we do not have a valid snapshot of segments yet (perhaps the underlying metadata store has
+   * not yet been polled.)
+   */
+  @Nullable
+  Collection<DataSegment> findOvershadowedSegments();
 
 Review comment:
   A method which is a simple getter shouldn't be called `find...`, implying high cost.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org