You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by dd...@apache.org on 2013/01/10 22:51:33 UTC
svn commit: r1431679 -
/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
Author: ddumont
Date: Thu Jan 10 21:51:33 2013
New Revision: 1431679
URL: http://svn.apache.org/viewvc?rev=1431679&view=rev
Log:
@Singleton
Closure compiler should be a singleton
Modified:
shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
Modified: shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java?rev=1431679&r1=1431678&r2=1431679&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java (original)
+++ shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java Thu Jan 10 21:51:33 2013
@@ -50,6 +50,7 @@ import com.google.common.collect.Immutab
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.inject.Inject;
+import com.google.inject.Singleton;
import com.google.inject.name.Named;
import com.google.javascript.jscomp.BasicErrorManager;
import com.google.javascript.jscomp.CheckLevel;
@@ -62,6 +63,7 @@ import com.google.javascript.jscomp.JSEr
import com.google.javascript.jscomp.Result;
import com.google.javascript.jscomp.SourceFile;
+@Singleton
public class ClosureJsCompiler implements JsCompiler {
// Default stack size for the compiler threads. The value was copied from closure compiler class.
private static final long DEFAULT_COMPILER_STACK_SIZE = 1048576L;
Re: svn commit: r1431679 - /shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
Posted by Dan Dumont <dd...@gmail.com>.
Not much is going on in that one.
On Thu, Jan 10, 2013 at 9:46 PM, Ryan Baxter <rb...@gmail.com> wrote:
> Dan don't we need the same change on the DefaultJsCompiler?
>
>
> On Thu, Jan 10, 2013 at 4:51 PM, <dd...@apache.org> wrote:
>
> > Author: ddumont
> > Date: Thu Jan 10 21:51:33 2013
> > New Revision: 1431679
> >
> > URL: http://svn.apache.org/viewvc?rev=1431679&view=rev
> > Log:
> > @Singleton
> > Closure compiler should be a singleton
> >
> > Modified:
> >
> >
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> >
> > Modified:
> >
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> > URL:
> >
> http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java?rev=1431679&r1=1431678&r2=1431679&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> > (original)
> > +++
> >
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> > Thu Jan 10 21:51:33 2013
> > @@ -50,6 +50,7 @@ import com.google.common.collect.Immutab
> > import com.google.common.collect.Lists;
> > import com.google.common.collect.Maps;
> > import com.google.inject.Inject;
> > +import com.google.inject.Singleton;
> > import com.google.inject.name.Named;
> > import com.google.javascript.jscomp.BasicErrorManager;
> > import com.google.javascript.jscomp.CheckLevel;
> > @@ -62,6 +63,7 @@ import com.google.javascript.jscomp.JSEr
> > import com.google.javascript.jscomp.Result;
> > import com.google.javascript.jscomp.SourceFile;
> >
> > +@Singleton
> > public class ClosureJsCompiler implements JsCompiler {
> > // Default stack size for the compiler threads. The value was copied
> > from closure compiler class.
> > private static final long DEFAULT_COMPILER_STACK_SIZE = 1048576L;
> >
> >
> >
>
Re: svn commit: r1431679 - /shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
Posted by Ryan Baxter <rb...@gmail.com>.
Dan don't we need the same change on the DefaultJsCompiler?
On Thu, Jan 10, 2013 at 4:51 PM, <dd...@apache.org> wrote:
> Author: ddumont
> Date: Thu Jan 10 21:51:33 2013
> New Revision: 1431679
>
> URL: http://svn.apache.org/viewvc?rev=1431679&view=rev
> Log:
> @Singleton
> Closure compiler should be a singleton
>
> Modified:
>
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
>
> Modified:
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> URL:
> http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java?rev=1431679&r1=1431678&r2=1431679&view=diff
>
> ==============================================================================
> ---
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> (original)
> +++
> shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
> Thu Jan 10 21:51:33 2013
> @@ -50,6 +50,7 @@ import com.google.common.collect.Immutab
> import com.google.common.collect.Lists;
> import com.google.common.collect.Maps;
> import com.google.inject.Inject;
> +import com.google.inject.Singleton;
> import com.google.inject.name.Named;
> import com.google.javascript.jscomp.BasicErrorManager;
> import com.google.javascript.jscomp.CheckLevel;
> @@ -62,6 +63,7 @@ import com.google.javascript.jscomp.JSEr
> import com.google.javascript.jscomp.Result;
> import com.google.javascript.jscomp.SourceFile;
>
> +@Singleton
> public class ClosureJsCompiler implements JsCompiler {
> // Default stack size for the compiler threads. The value was copied
> from closure compiler class.
> private static final long DEFAULT_COMPILER_STACK_SIZE = 1048576L;
>
>
>