[PR] Improved: MacroFormRenderer builds the form structure and hyperlink macro calls with RenderableFtlFormElementsBuilder (OFBIZ-13680) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2330:
URL: https://github.com/apache/ofbiz-framework/pull/2330

   MacroFormRenderer built the macro calls of the form structure (form, list and row wrappers, header, cell and field row macros, boundary comments) and of the hyperlinks as text and compiled them. RenderableFtlFormElementsBuilder now creates these macro calls, so that FtlWriter passes their values as data, and the hand-built copy of the hyperlink code in MacroFormRenderer is replaced by the one that the builder already had, which now gives the same output. The macro signatures and the output are unchanged, except that values containing a quote, a backslash or an interpolation, which used to fail to render or to be evaluated, are now rendered as they are, and a missing value is rendered as an empty string instead of the text "null". The code that the builder shares with the renderer is fixed in these ways:
   
   - the parameters of a layered modal link are passed as the JSON string that the macro expects, with the presentation layer, instead of as a map, and the text of the link is passed as well.
   - the form of a hidden form link in a multi form is written after the closing of the multi form, which never happened for the sub hyperlinks of the display entity and text fields.
   - FtlWriter writes a RenderableFtlString as it is instead of compiling it as a template, so that an interpolation in the description of a hidden form link is not evaluated.
   - the description of a hidden form link with a quote does not show a backslash before the quote anymore.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: MacroFormRenderer builds the form structure and hyperlink macro calls with RenderableFtlFormElementsBuilder (OFBIZ-13680) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2330:
URL: https://github.com/apache/ofbiz-framework/pull/2330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org