You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/09/06 19:18:06 UTC

[kudu-CR] [tests] fix flakes in delete table-itest

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7972

to look at the new patch set (#3).

Change subject: [tests] fix flakes in delete_table-itest
......................................................................

[tests] fix flakes in delete_table-itest

Fixed flakes in DeleteTableITest.TestNoDeleteTombstonedTablets:

* If a leader election happened in the middle of the
  AddServer/RemoveServer sequence, the test failed with an error
  message like the following:

    src/kudu/integration-tests/delete_table-itest.cc:1217: Failure
    Failed
    Bad status: Illegal state: Replica 37783b00d5d34ffe87953cb90fa60e7c\
      is not leader of this config. Role: FOLLOWER.

* If more than a couple of heartbeats from the evicted node were
  received, the test failed with an error message like the following:

    src/kudu/integration-tests/delete_table-itest.cc:1241: Failure
    Expected: (num_delete_attempts) <= (kMaxDeleteAttemptsPerEviction),\
      actual: 5 vs 3
    src/kudu/util/test_util.cc:283: Failure
    Failed
    Timed out waiting for assertion to pass

Prior to the fix, running tests against a DEBUG build,
there were about 3 failures per 1K run:
  http://dist-test.cloudera.org/job?job_id=aserbin.1504655654.10466

After the fix, there were no failures in multiple 1K runs:
  http://dist-test.cloudera.org/job?job_id=aserbin.1504670739.3127

Change-Id: I7dda40ae1054becaf25963a6d301ecaed5a926f9
---
M src/kudu/integration-tests/delete_table-itest.cc
1 file changed, 108 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/7972/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dda40ae1054becaf25963a6d301ecaed5a926f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot