You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/06 09:36:15 UTC

[GitHub] [hbase] wchevreuil commented on a change in pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

wchevreuil commented on a change in pull request #2206:
URL: https://github.com/apache/hbase/pull/2206#discussion_r466283735



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -178,7 +179,7 @@ private void scheduleRelogin(Throwable error) {
     RELOGIN_EXECUTOR.schedule(() -> {
       try {
         provider.relogin();
-      } catch (IOException e) {
+      } catch (Throwable e) {

Review comment:
       Yeah, I think it makes sense. IIRC, netty swallows the throwable silently, so it's difficult to figure out what's wrong.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org