You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/30 02:20:34 UTC
[GitHub] [pulsar] Technoboy- commented on a change in pull request #11455: Fix Consumer listener does not respect receiver queue size
Technoboy- commented on a change in pull request #11455:
URL: https://github.com/apache/pulsar/pull/11455#discussion_r679602285
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -895,24 +897,28 @@ private void pendingBatchReceiveTask(Timeout timeout) throws Exception {
protected void triggerListener() {
// Trigger the notification on the message listener in a separate thread to avoid blocking the networking
// thread while the message processing happens
- Message<T> msg;
- do {
- try {
- msg = internalReceive(0, TimeUnit.MILLISECONDS);
+ try {
+ while (executorQueueSize.get() < conf.getReceiverQueueSize()) {
Review comment:
ZeroQueueConsumerImpl has override the triggerListener:
```java
@Override
protected void triggerListener() {
// Ignore since it was already triggered in the triggerZeroQueueSizeListener() call
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org