[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions

["spmallette (via GitHub)" <gi...@apache.org>]

spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192615914


##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
      minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
        - shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
        - for details, see licenses/minlog
+     Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4

Review Comment:
   the groovy jar LICENSE already references ANTLR (not the detail level we do, but i suppose that is their style). i don't think we need to do it again. it just complicates our LICENSE. simply including 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org