You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by selvaganesang <gi...@git.apache.org> on 2017/10/20 19:15:51 UTC
[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...
GitHub user selvaganesang opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1273
[TRAFODION-2780] The mxosrvr dumps core when connection idle timer ex…
…pires at times
This core is accompanied by mxssmp process core.
Got rid of both connection idle timer and server idle timer, instead use the timeout
mechanism provided by the socket API select. More code removed.
Tested the connection idle timeout mechanism via a sample JDBC T4 program just to ensure
that the mxosrvr is put into available pool after the connection idle timer expires.
Trafci seems to be resetting the connection idle timer periodically from the client.
It looks like even the connection idle timer is Trafodion specific concept because of
a dedicated process for every database connection to Trafodion SQL engine. From JDBC specification,
the connection inactive timeout needs to be implemented in the connection pooling infrastructure.
The default connection idle timer in Trafodion is 10 mins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/selvaganesang/incubator-trafodion conn_idle_timer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
----
commit acfb5b296bac5e9f7a1d7236107fc262fe26812c
Author: selvaganesang <se...@esgyn.com>
Date: 2017-10-20T19:08:04Z
[TRAFODION-2780] The mxosrvr dumps core when connection idle timer expires at times
This core is accompanied by mxssmp process core.
Got rid of both connection idle timer and server idle timer, instead use the timeout
mechanism provided by the socket API select. More code removed.
Tested the connection idle timeout mechanism via a sample JDBC T4 program just to ensure
that the mxosrvr is put into available pool after the connection idle timer expires.
Trafci seems to be resetting the connection idle timer periodically from the client.
It looks like even the connection idle timer is Trafodion specific concept because of
a dedicated process for every database connection to Trafodion SQL engine. From JDBC specification,
the connection inactive timeout needs to be implemented in the connection pooling infrastructure.
The default connection idle timer in Trafodion is 10 mins.
----
---
[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...
Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1273#discussion_r146346584
--- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp ---
@@ -1190,10 +1176,6 @@ ImplInit (
srvrGlobal->receiveThrId = getpid();
timer_register();
--- End diff --
Thanks for the change Selva.
Could you please undo the change for StatisticsTimerHandle ? Thanks
---
[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1273
---
[GitHub] incubator-trafodion pull request #1273: [TRAFODION-2780] The mxosrvr dumps c...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1273#discussion_r146354070
--- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp ---
@@ -1190,10 +1176,6 @@ ImplInit (
srvrGlobal->receiveThrId = getpid();
timer_register();
--- End diff --
Thanks for catching this inadvertent deletion of timer initialization call.
---