You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "abmodi (via GitHub)" <gi...@apache.org> on 2023/08/13 05:35:55 UTC
[GitHub] [spark] abmodi opened a new pull request, #42475: Fixing pipelineTime metric for WholeStageCodegen
abmodi opened a new pull request, #42475:
URL: https://github.com/apache/spark/pull/42475
### What changes were proposed in this pull request?
Instead of adding values for pipelineTime, setting value to avoid multiple additions.
### Why are the changes needed?
Fixing incorrect pipelineTime metric for WholeStageCodegen
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44793][SQL] Fixing pipelineTime metric for WholeStageCodegen [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42475: [SPARK-44793][SQL] Fixing pipelineTime metric for WholeStageCodegen
URL: https://github.com/apache/spark/pull/42475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42475: [SPARK-44793][SQL] Fixing pipelineTime metric for WholeStageCodegen
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42475:
URL: https://github.com/apache/spark/pull/42475#discussion_r1299546504
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenEvaluatorFactory.scala:
##########
@@ -41,7 +41,7 @@ class WholeStageCodegenEvaluatorFactory(
new Iterator[InternalRow] {
override def hasNext: Boolean = {
val v = buffer.hasNext
- if (!v) durationMs += buffer.durationMs()
+ if (!v) durationMs.set(buffer.durationMs())
Review Comment:
why and how was this wrong?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenEvaluatorFactory.scala:
##########
@@ -41,7 +41,7 @@ class WholeStageCodegenEvaluatorFactory(
new Iterator[InternalRow] {
override def hasNext: Boolean = {
val v = buffer.hasNext
- if (!v) durationMs += buffer.durationMs()
+ if (!v) durationMs.set(buffer.durationMs())
Review Comment:
and how did you test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44793][SQL] Fixing pipelineTime metric for WholeStageCodegen [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42475:
URL: https://github.com/apache/spark/pull/42475#issuecomment-1832904207
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org