You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org> on 2006/09/27 13:25:16 UTC
[jira] Created: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
----------------------------------------------------------------------------
Key: ADFFACES-203
URL: http://issues.apache.org/jira/browse/ADFFACES-203
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Matthias Weßendorf
Assigned To: Matthias Weßendorf
Priority: Minor
Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=all ]
Adam Winer updated ADFFACES-203:
--------------------------------
Status: Open (was: Patch Available)
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=all ]
Matthias Weßendorf updated ADFFACES-203:
----------------------------------------
Status: Patch Available (was: Open)
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-203:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: https://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=comments#action_12438261 ]
Adam Winer commented on ADFFACES-203:
-------------------------------------
I really don't want to remove the single String renderStyleClass(); this method
is so commonly called that avoiding the String array creation (needed for varargs) is valuable.
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=all ]
Matthias Weßendorf updated ADFFACES-203:
----------------------------------------
Attachment: patch203.patch
usage of size 1 array doesn't need StringBuilder for instance
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=all ]
Adam Winer resolved ADFFACES-203.
---------------------------------
Resolution: Invalid
Developers should be using the single-arg renderStyleClass() method when there's only one styleclass.
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=comments#action_12439358 ]
Jeanne Waldman commented on ADFFACES-203:
-----------------------------------------
I agree with Adam.
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-203) overhaul
CoreRenderer.renderStyleClasses() for usage with String[] of size 1
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-203?page=comments#action_12438164 ]
Matthias Weßendorf commented on ADFFACES-203:
---------------------------------------------
from Simon's email
Hello all,
Currently that method requires a string array and it's kind of annoying to
use because of that. Java 5 offers varargs that would make its usage much
more interesting imho. So I would like to merge both renderStyleClasses in a
single one using the following signature:
public static void renderStyleClasses(FacesContext context, RenderingContext
arc, String... styleClasses);
Backward compatiblity should be kept as varargs allow both array and
sequence of arguments to be passed.
Any objection?
> overhaul CoreRenderer.renderStyleClasses() for usage with String[] of size 1
> ----------------------------------------------------------------------------
>
> Key: ADFFACES-203
> URL: http://issues.apache.org/jira/browse/ADFFACES-203
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Matthias Weßendorf
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: patch203.patch
>
>
> Ensure an efficient algor. for usage of renderStyleClasses() w/ an array of size one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira