[GitHub] [tvm] tkonolige commented on pull request #11676: [FIX,METASCHEDULER] Fix tune_te

[GitBox <gi...@apache.org>]

tkonolige commented on PR #11676:
URL: https://github.com/apache/tvm/pull/11676#issuecomment-1152782458

   
   > 1. `tune_tir` supports tuning of PrimFunc directly. The test could work without the modification.
   
   It does not. If you try running without the change to tune.py you will see the test fails.
   
   > 2. The test was skipped because it's an integration test not because it's broken. We prefer unittests instead of integration tests in CI.
   > May I ask if there's any particular reason that we might want to enable this test or put PrimFunc into an IRModule? If you prefer to enable this test I think it would be great if we create a unit test instead for your need : )
   
   Without this test (that you created?) there is no test for `tune_te`. That is how this error got into mainline.
   
   > While the tests are disabled only because we think it's more like an integration test that takes time to run, which is not good for the CI
   
   The test takes 4 seconds on my machine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org