You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "georgew5656 (via GitHub)" <gi...@apache.org> on 2023/04/08 03:28:21 UTC
[GitHub] [druid] georgew5656 opened a new pull request, #14052: Add snakeyaml dependency back in
georgew5656 opened a new pull request, #14052:
URL: https://github.com/apache/druid/pull/14052
### Description
While doing some testing on my other PR (https://github.com/apache/druid/pull/14030) with the new fabric8 library version, I noticed some snakeyaml error when starting up the overlord. We need to add the snakeyaml library into the pom still as fabric8 6.4.1 still depends on it
This PR has:
- [X ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [X ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] nlippis commented on pull request #14052: Add snakeyaml dependency back in
Posted by "nlippis (via GitHub)" <gi...@apache.org>.
nlippis commented on PR #14052:
URL: https://github.com/apache/druid/pull/14052#issuecomment-1508562737
Let's hold off on this change. The reason to put it in was so that the snakeyaml dependency would be included in the bundle. Adding this into the pom does not seem to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] georgew5656 closed pull request #14052: Add snakeyaml dependency back in
Posted by "georgew5656 (via GitHub)" <gi...@apache.org>.
georgew5656 closed pull request #14052: Add snakeyaml dependency back in
URL: https://github.com/apache/druid/pull/14052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] georgew5656 commented on pull request #14052: Add snakeyaml dependency back in
Posted by "georgew5656 (via GitHub)" <gi...@apache.org>.
georgew5656 commented on PR #14052:
URL: https://github.com/apache/druid/pull/14052#issuecomment-1508022431
> the dependency checker part of ci seems to be complaining that this dependency is not used, should we just ignore it?
>
>
>
> ```
>
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ druid-kubernetes-overlord-extensions ---
>
> Warning: Unused declared dependencies found:
>
> Warning: org.yaml:snakeyaml:jar:1.33:compile
>
> ```
let me check if updating the version will help, i can see what version of snakeyaml fabric8 uses exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #14052: Add snakeyaml dependency back in
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #14052:
URL: https://github.com/apache/druid/pull/14052#issuecomment-1506334303
the dependency checker part of ci seems to be complaining that this dependency is not used, should we just ignore it?
```
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ druid-kubernetes-overlord-extensions ---
Warning: Unused declared dependencies found:
Warning: org.yaml:snakeyaml:jar:1.33:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org