You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2022/11/29 05:29:50 UTC

[logging-log4j-server] 09/32: [LOG4J2-1994] TcpSocketServer does not close accepted Sockets. Comment.

This is an automated email from the ASF dual-hosted git repository.

rgoers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j-server.git

commit 5c06888bd7086d7912d8a7411f99846e5f3641e2
Author: Gary Gregory <gg...@apache.org>
AuthorDate: Fri Jul 28 16:11:00 2017 -0700

    [LOG4J2-1994] TcpSocketServer does not close accepted Sockets. Comment.
---
 .../src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java b/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
index af458f8..7fde56b 100644
--- a/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
+++ b/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
@@ -346,6 +346,7 @@ public class TcpSocketServer<T extends InputStream> extends AbstractSocketServer
             try {
                 // Accept incoming connections.
                 logger.debug("Listening for a connection {}...", serverSocket);
+                @SuppressWarnings("resource") // clientSocket is closed during SocketHandler shutdown
                 final Socket clientSocket = serverSocket.accept();
                 logger.debug("Acepted connection on {}...", serverSocket);
                 logger.debug("Socket accepted: {}", clientSocket);