You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2025/01/31 23:57:32 UTC
[PR] Fix set position [datasketches-memory]
leerho opened a new pull request, #254:
URL: https://github.com/apache/datasketches-memory/pull/254
I had to fix all the tests in
- NativeWritableBufferImplTest
- NativeWritableMemoryImplTest
- NonNativeWritableBufferImplTest
- NonNativeWritableMemoryTest
to be able to detect this particular bug.
I also updated the logic in the 4 leaf classes:
- NativeWritableBufferImpl
- NativeWritableMemoryImpl
- NonNativeWritableBufferImpl
- NonNativeWritableMemoryImpl
to take advantage of new APIs in the Java 21 version of FFM. This eliminated a whole bunch of unnecessary code, and made the code in these files much easier to read and debug!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Fix set position [datasketches-memory]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #254:
URL: https://github.com/apache/datasketches-memory/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org