[jira] [Commented] (SLING-2634) [Tooling] Slingclipse should expose the operations it performs and their results

["Robert Munteanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490760#comment-13490760 ] 

Robert Munteanu commented on SLING-2634:
----------------------------------------

I've worked a little on exposing the internals of the operations and their result for logging.

I have the following high-level approach:

- no logging dependency added to the http bundle as this is expected to be embeddable and used outside Eclipse
- added a tracer class using the platform debug API supplied by Eclipse to the base bundle, which is an Eclipse plugin anyway
- as a proof-of-design ( not even tested properly :-) ) I made the Repository return Command objects to be executed which expose the Result after the execution ; this was done only for the addFileInfo command

I've made only minimal changes ( and still have some whitespace diffs in , sorry ) since I want to validate the high-level approach with you and only then complete the implementation.
                
> [Tooling] Slingclipse should expose the operations it performs and their results
> --------------------------------------------------------------------------------
>
>                 Key: SLING-2634
>                 URL: https://issues.apache.org/jira/browse/SLING-2634
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Robert Munteanu
>            Priority: Minor
>         Attachments: SLING-2634-proof-of-design.diff
>
>
> I think that it's important for the user to know what Slingclipse is doing, especially since it uses some heuristics to detect Sling-based projects.
> My first thoughts would be: 
> * from a UI point of view start with something simple like a text-only console . The subclipse console is a good starting point, we can simply log things like
> ADD $SLING_URL $PROJECT/$RESOURCE 200 OK
> REMOVE $SLING_URL $PROJECT/$RESOURCE 500 Internal Server Error
> * from an implementation point of view we could use something like a command pattern ( SaveResource command, DeleteResourceCommand ) . This would have the benefit of allowing this logging easily + encapsulating the operations for batching, handling of offline operations, redo etc.
> Thoughts? I'm willing to look into this, at least for a first iteration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira