You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2021/10/09 22:54:00 UTC

[jira] [Resolved] (ORC-1021) Add -fno-omit-frame-pointer in RELWITHDEBINFO build

     [ https://issues.apache.org/jira/browse/ORC-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved ORC-1021.
--------------------------------
    Fix Version/s: 1.8.0
       Resolution: Fixed

This is resolved via https://github.com/apache/orc/pull/932

> Add -fno-omit-frame-pointer in RELWITHDEBINFO build
> ---------------------------------------------------
>
>                 Key: ORC-1021
>                 URL: https://issues.apache.org/jira/browse/ORC-1021
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>             Fix For: 1.8.0
>
>
> [~drorke] points out that it'd be helpful to add the -fno-omit-frame-pointer option in release builds, which helps to generate flame graphs for deep stacks [1]. 
> The option is already used in release builds of Impala and we found the performance penalty is small (IMPALA-4132). As we have two release modes, i.e. RELEASE and RELWITHDEBINFO with symbols, we can add this option to RELWITHDEBINFO builds.
> [1]: [https://www.brendangregg.com/perf.html#StackTraces]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)