You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ni...@apache.org on 2015/02/23 14:21:23 UTC
svn commit: r1661663 - in /poi/trunk:
src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java
test-data/openxml4j/OPCCompliance_NoCoreProperties.xlsx
Author: nick
Date: Mon Feb 23 13:21:23 2015
New Revision: 1661663
URL: http://svn.apache.org/r1661663
Log:
Unit tests for OPC handling of files without a Core Properties part
Added:
poi/trunk/test-data/openxml4j/OPCCompliance_NoCoreProperties.xlsx (with props)
Modified:
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java?rev=1661663&r1=1661662&r2=1661663&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java Mon Feb 23 13:21:23 2015
@@ -17,6 +17,10 @@
package org.apache.poi.openxml4j.opc.compliance;
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
@@ -34,6 +38,8 @@ import org.apache.poi.openxml4j.opc.OPCP
import org.apache.poi.openxml4j.opc.PackageRelationshipTypes;
import org.apache.poi.openxml4j.opc.PackagingURIHelper;
import org.apache.poi.openxml4j.opc.TargetMode;
+import org.apache.poi.util.IOUtils;
+import org.apache.poi.util.TempFile;
/**
* Test core properties Open Packaging Convention compliance.
@@ -224,4 +230,79 @@ public final class TestOPCComplianceCore
String msg = extractInvalidFormatMessage("LimitedXSITypeAttribute_PresentWithUnauthorizedValueFAIL.docx");
assertEquals("The element 'modified' must have the 'xsi:type' attribute with the value 'dcterms:W3CDTF' !", msg);
}
+
+ /**
+ * Document with no core properties - testing at the OPC level,
+ * saving into a new stream
+ */
+ public void testNoCoreProperties_saveNew() throws Exception {
+ String sampleFileName = "OPCCompliance_NoCoreProperties.xlsx";
+ OPCPackage pkg = null;
+ try {
+ pkg = OPCPackage.open(POIDataSamples.getOpenXML4JInstance().getFile(sampleFileName).getPath());
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+
+ // Empty properties
+ assertEquals(0, pkg.getPartsByContentType(ContentTypes.CORE_PROPERTIES_PART).size());
+ assertNotNull(pkg.getPackageProperties());
+ assertNotNull(pkg.getPackageProperties().getLanguageProperty());
+ assertNull(pkg.getPackageProperties().getLanguageProperty().getValue());
+
+ // Save and re-load
+ ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ pkg.save(baos);
+ ByteArrayInputStream bais = new ByteArrayInputStream(baos.toByteArray());
+
+ pkg = OPCPackage.open(bais);
+
+ // An Empty Properties part has been added in the save/load
+ assertEquals(1, pkg.getPartsByContentType(ContentTypes.CORE_PROPERTIES_PART).size());
+ assertNotNull(pkg.getPackageProperties());
+ assertNotNull(pkg.getPackageProperties().getLanguageProperty());
+ assertNull(pkg.getPackageProperties().getLanguageProperty().getValue());
+ }
+
+ /**
+ * Document with no core properties - testing at the OPC level,
+ * from a temp-file, saving in-place
+ */
+ public void testNoCoreProperties_saveInPlace() throws Exception {
+ String sampleFileName = "OPCCompliance_NoCoreProperties.xlsx";
+
+ // Copy this into a temp file, so we can play with it
+ File tmp = TempFile.createTempFile("poi-test", ".opc");
+ FileOutputStream out = new FileOutputStream(tmp);
+ IOUtils.copy(
+ POIDataSamples.getOpenXML4JInstance().openResourceAsStream(sampleFileName),
+ out);
+ out.close();
+
+ // Open it from that temp file
+ OPCPackage pkg = OPCPackage.open(tmp);
+
+ // Empty properties
+ assertEquals(0, pkg.getPartsByContentType(ContentTypes.CORE_PROPERTIES_PART).size());
+ assertNotNull(pkg.getPackageProperties());
+ assertNotNull(pkg.getPackageProperties().getLanguageProperty());
+ assertNull(pkg.getPackageProperties().getLanguageProperty().getValue());
+
+ // Save and close
+ pkg.close();
+
+
+ // Re-open and check
+ pkg = OPCPackage.open(tmp);
+
+ // An Empty Properties part has been added in the save/load
+ assertEquals(1, pkg.getPartsByContentType(ContentTypes.CORE_PROPERTIES_PART).size());
+ assertNotNull(pkg.getPackageProperties());
+ assertNotNull(pkg.getPackageProperties().getLanguageProperty());
+ assertNull(pkg.getPackageProperties().getLanguageProperty().getValue());
+
+ // Finish and tidy
+ pkg.revert();
+ tmp.delete();
+ }
}
Added: poi/trunk/test-data/openxml4j/OPCCompliance_NoCoreProperties.xlsx
URL: http://svn.apache.org/viewvc/poi/trunk/test-data/openxml4j/OPCCompliance_NoCoreProperties.xlsx?rev=1661663&view=auto
==============================================================================
Binary file - no diff available.
Propchange: poi/trunk/test-data/openxml4j/OPCCompliance_NoCoreProperties.xlsx
------------------------------------------------------------------------------
svn:mime-type = application/octet-stream
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org