You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/04/16 16:38:00 UTC

[jira] [Commented] (IMPALA-13961) Remove usage of ImpalaBeeswaxResult.schema

    [ https://issues.apache.org/jira/browse/IMPALA-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945127#comment-17945127 ] 

ASF subversion and git services commented on IMPALA-13961:
----------------------------------------------------------

Commit b46d5415018feb8e2d64a5b0e111d8aa96999d03 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b46d54150 ]

IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema

An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.

This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.

Testing:
Run and pass modified test files in exhaustive exploration.

Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Reviewed-on: http://gerrit.cloudera.org:8080/22776
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Remove usage of ImpalaBeeswaxResult.schema
> ------------------------------------------
>
>                 Key: IMPALA-13961
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13961
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> An equivalent of ImpalaBeeswaxResult.schema is not implemented at ImpylaHS2ResultSet.
> [https://github.com/apache/impala/blob/047cf9ff4d3c68c32be0965fbc3cb0c245d3b3b1/tests/beeswax/impala_beeswax.py#L81]
> However, both column_labels and column_types fields are implemented for both.
> [https://github.com/apache/impala/blob/047cf9ff4d3c68c32be0965fbc3cb0c245d3b3b1/tests/beeswax/impala_beeswax.py#L86-L87]
> [https://github.com/apache/impala/blob/047cf9ff4d3c68c32be0965fbc3cb0c245d3b3b1/tests/common/impala_connection.py#L941-L942] 
> We should remove usage of ImpalaBeeswaxResult.schema and replace it with either column_labels or column_types field.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org