You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2023/04/10 19:25:00 UTC
[jira] [Commented] (IGNITE-18766) Incorrect id check in ClusterGroupAdapter.forNodeId
[ https://issues.apache.org/jira/browse/IGNITE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710274#comment-17710274 ]
Ignite TC Bot commented on IGNITE-18766:
----------------------------------------
{panel:title=Branch: [pull/10640/head] Base: [master] : Possible Blockers (4)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 6{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=7132577]]
* IgniteCacheTestSuite6: CacheExchangeMergeTest.testMergeAndHistoryCleanup - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Cache 12{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=7132571]]
* IgniteCacheTestSuite12: TxCrossCacheRemoteMultiplePartitionReservationTest.testRemoteCommitPartitionReservations - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Cache (Failover) 1{color} [[tests 0 TIMEOUT , Exit Code , Failure on metric |https://ci2.ignite.apache.org/viewLog.html?buildId=7132583]]
{color:#d04437}PDS 5{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=7132630]]
* IgnitePdsTestSuite5: SegmentAwareTest.testFinishWaitNextAbsoluteIndex_WhenSetToArchivedFirst - Test has low fail rate in base branch 0,0% and is not flaky
{panel}
{panel:title=Branch: [pull/10640/head] Base: [master] : New Tests (1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 1{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=7132563]]
* {color:#013220}IgniteBasicTestSuite: GridProjectionForCachesSelfTest.testProjectionWithBadId - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=7132674&buildTypeId=IgniteTests24Java8_RunAll]
> Incorrect id check in ClusterGroupAdapter.forNodeId
> ---------------------------------------------------
>
> Key: IGNITE-18766
> URL: https://issues.apache.org/jira/browse/IGNITE-18766
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.14
> Reporter: Pavel Tupitsyn
> Assignee: Denis Kuznetsov
> Priority: Minor
> Labels: ise, newbie
> Fix For: 2.15
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ClusterGroup.forNodeId checks *id* in a loop instead of *id0*:
> {code:java}
> for (UUID id0 : ids) {
> if (contains(id))
> nodeIds.add(id0);
> }
> {code}
> https://github.com/apache/ignite/blob/3de1dc44f53ea510328badf6cb6b423fe6975bd8/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L461
> The following unit test demonstrates the problem:
> {code:java}
> @Test
> public void testProjectionWithBadId() {
> ClusterNode locNode = ignite.cluster().localNode();
> ClusterGroup prj = ignite.cluster().forNodeId(UUID.randomUUID(), locNode.id());
> Collection<ClusterNode> nodes = prj.nodes();
> assertEquals(1, nodes.size());
> }
> {code}
> (add to GridProjectionForCachesSelfTest)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)