You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "darinspivey (via GitHub)" <gi...@apache.org> on 2026/04/23 13:53:48 UTC

[PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

darinspivey opened a new pull request, #25572:
URL: https://github.com/apache/pulsar/pull/25572

   Topics with compaction enabled — most visibly `__change_events` system topics — accumulate an unbounded `__compaction` subscription backlog that is never drained, polluting backlog metrics across the cluster.
   
   The broker disconnects the compaction consumer as part of `PersistentSubscription.resetCursorInternal`, then resets the cursor and sends the success response. This races with the client: `channelInactive` fires on the consumer's `ClientCnx` and fails the in-flight seek future with `ConnectException` before the broker's success response arrives.
   
   `AbstractTwoPhaseCompactor.phaseTwoSeekThenLoop` has no retry for this transient failure, so every compaction attempt aborts and the `__compaction` subscription backlog grows without bound. This is most visible on `__change_events` system topics, where compaction is triggered on any non-zero backlog.
   
   The seek is idempotent and the cursor is already repositioned server-side, so retry the seek on `ConnectException` with a bounded backoff (100ms -> 1s, 10s budget). Non-transient failures propagate immediately. A unit test reproduces the race via an injection hook and asserts the compactor recovers.
   
   Fixes #25279
   
   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   <!-- Either this PR fixes an issue, -->
   
   Fixes #xyz
   
   <!-- or this PR is one task of an issue -->
   
   Main Issue: #xyz
   
   <!-- If the PR belongs to a PIP, please add the PIP link here -->
   
   PIP: #xyz 
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
   
   ### Motivation
   
   <!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
   
   ### Modifications
   
   <!-- Describe the modifications you've done. -->
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "darinspivey (via GitHub)" <gi...@apache.org>.
darinspivey commented on PR #25572:
URL: https://github.com/apache/pulsar/pull/25572#issuecomment-4343488251

   @merlimat Thanks for your attention and approval on this PR.  I've added a commit that hopefully fixes the test injection design for my new test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "darinspivey (via GitHub)" <gi...@apache.org>.
darinspivey commented on PR #25572:
URL: https://github.com/apache/pulsar/pull/25572#issuecomment-4352352710

   Thanks for that tip on personal CI, @lhotari .  I'll do that in the future.  In the meantime, I meant to sync my fork's master branch, but accidentally sync'd the feature branch.  CI will have to be kicked off again, sorry.  I won't touch it from here on out.  Good to know about "/pulsarbot rerun" too!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #25572:
URL: https://github.com/apache/pulsar/pull/25572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25572:
URL: https://github.com/apache/pulsar/pull/25572#issuecomment-4350351181

   > The remaining CI failures appear to be out of my control
   
   when CI fails due to flaky tests, you can add a comment "/pulsarbot rerun" to trigger a retry.
   For early stage PRs, it's worth setting up ["Personal CI"](https://pulsar.apache.org/contribute/personal-ci/) where you have full control.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "darinspivey (via GitHub)" <gi...@apache.org>.
darinspivey commented on PR #25572:
URL: https://github.com/apache/pulsar/pull/25572#issuecomment-4346005801

   The remaining CI failures appear to be out of my control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][broker] Race condition causes perpetual backlog on internal topics [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25572:
URL: https://github.com/apache/pulsar/pull/25572#issuecomment-4350352261

   /pulsarbot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org