[GitHub] [airflow] mik-laj commented on a change in pull request #10308: Adds a role based authentication backend for the experimental API

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #10308:
URL: https://github.com/apache/airflow/pull/10308#discussion_r469603674



##########
File path: airflow/api/auth/backend/role_based_auth.py
##########
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Role based authentication backend - access is based on user roles."""
+from functools import wraps
+from typing import Callable, Optional, Tuple, TypeVar, Union
+
+from flask import Response
+from requests.auth import AuthBase
+
+from airflow.www.app import cached_app
+
+CLIENT_AUTH: Optional[Union[Tuple[str, str], AuthBase]] = None
+
+
+def init_app(_):
+    """Initializes authentication backend"""
+
+
+T = TypeVar("T", bound=Callable)  # pylint: disable=invalid-name
+
+
+def requires_authentication(function):
+    """Decorator for functions that require authentication"""
+
+    @wraps(function)
+    def decorated(*args, **kwargs):
+        appbuilder = cached_app().appbuilder  # pylint: disable=no-member

Review comment:
       ```suggestion
           appbuilder = current_app.appbuilder  # pylint: disable=no-member
   ```
   Please use Flask.current_app. This makes it harder to create side effects.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org