You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/08/10 16:46:30 UTC
svn commit: r1371725 -
/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java
Author: rmuir
Date: Fri Aug 10 14:46:30 2012
New Revision: 1371725
URL: http://svn.apache.org/viewvc?rev=1371725&view=rev
Log:
ignore silly bugs in sun's regex impl
Modified:
lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java
Modified: lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java?rev=1371725&r1=1371724&r2=1371725&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java (original)
+++ lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/_TestUtil.java Fri Aug 10 14:46:30 2012
@@ -956,9 +956,18 @@ public class _TestUtil {
while (true) {
try {
Pattern p = Pattern.compile(_TestUtil.randomRegexpishString(random));
+ String replacement = null;
+ // ignore bugs in Sun's regex impl
+ try {
+ replacement = p.matcher(nonBmpString).replaceAll("_");
+ } catch (StringIndexOutOfBoundsException jdkBug) {
+ System.out.println("WARNING: your jdk is buggy!");
+ System.out.println("Pattern.compile(\"" + p.pattern() +
+ "\").matcher(\"AB\\uD840\\uDC00C\").replaceAll(\"_\"); should not throw IndexOutOfBounds!");
+ }
// Make sure the result of applying the pattern to a string with extended
// unicode characters is a valid utf16 string. See LUCENE-4078 for discussion.
- if (UnicodeUtil.validUTF16String(p.matcher(nonBmpString).replaceAll("_"))) {
+ if (replacement != null && UnicodeUtil.validUTF16String(replacement)) {
return p;
}
} catch (PatternSyntaxException ignored) {