Re: [PR] API, Core: Introduce a generic abstraction to replace ManifestListFile [iceberg]

["anoopj (via GitHub)" <gi...@apache.org>]

anoopj commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r3817543489


##########
core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java:
##########
@@ -140,19 +141,33 @@ public static ByteBuffer setFileLength(ByteBuffer keyMetadata, long fileLength)
    * @param manifestList a ManifestListFile
    * @param em the table's EncryptionManager
    * @return a decrypted key metadata buffer
+   * @deprecated since 1.12.0. Will be removed in 1.13.0; use {@link

Review Comment:
   Shouldn't the removal version be the next major version (`2.0.0`) as you have done in the other deprecation tag in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org