NetAddr::IP's use of $& and $`

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

Hi Luis and Michael,

Would you be able to consider reworking NetAddr::IP to avoid the use of, 
or loading of anything that uses, $& or $` so that the huge speed 
penalty imposed by Perl when doing so can be avoided?

NetAddr::IP is used by Mail::SPF which is used by Mail::SpamAssassin. 
Apache SpamAssassin needs to avoid the speed penalty imposed by $& and 
$` at all costs.

Please see SpamAssassin bug 5312 for some background on this:
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5312

Thanks!

Regards,

Daryl C. W. O'Shea
Apache SpamAssassin PMC Member

Re: NetAddr::IP's use of $& and $`

["Luis E. Muñoz" <lu...@cpan.org>]

On Jun 6, 2007, at 12:46 PM, Daryl C. W. O'Shea wrote:

> Hi Luis and Michael,
>
> Would you be able to consider [...]

I will, time permitting. Patches welcome :-)

I'll take a look at the bug report in a short while (I hope!)

Thanks for pointing this out.

-lem

Re: NetAddr::IP's use of $& and $`

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

Luis E. Muñoz wrote:
> 
> On Jun 6, 2007, at 12:46 PM, Daryl C. W. O'Shea wrote:
> 
>> Would you be able to consider reworking NetAddr::IP to avoid the use 
>> of, or loading of anything that uses, $& or $` so that the huge speed 
>> penalty imposed by Perl when doing so can be avoided?
> 
> Please find attached the next RC for NetAddr::IP - I'll await your 
> confirmation that your tests pass before uploading to CPAN.

I will install it and run a make test for both Mail::SPF and 
Mail::SpamAssassin (it does some more SPF testing).

I'll also forward a copy to Mark Martinec (amavisd-new maintainer) who 
spotted the issue and Julian Mehnle (Mail::SPF maintainer).


> Thanks for the report.

No problem.  Thank you for the super fast response!


Daryl

Re: NetAddr::IP's use of $& and $`

["Luis E. Muñoz" <lu...@cpan.org>]

On Jun 6, 2007, at 12:46 PM, Daryl C. W. O'Shea wrote:

> Would you be able to consider reworking NetAddr::IP to avoid the  
> use of, or loading of anything that uses, $& or $` so that the huge  
> speed penalty imposed by Perl when doing so can be avoided?

Please find attached the next RC for NetAddr::IP - I'll await your  
confirmation that your tests pass before uploading to CPAN.

Thanks for the report.

-lem

Re: NetAddr::IP's use of $& and $`

[Julian Mehnle <ju...@mehnle.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daryl C. W. O'Shea wrote:
> NetAddr::IP v4.007 removes everything that would cause PL_sawampersand
> to be set to true.

The next Mail::SPF release will explicitly _recommend_ NetAddr::IP v4.007, 
but will (obviously) still _strictly_require_ only v4.000.

Present Mail::SPF releases should work fine as-is with NetAddr::IP v4.007.

Julian.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGZ9jNwL7PKlBZWjsRAhhwAJ9TCarw4e5tasf7xQHQf5hGfEv27ACfSe38
ywaaKXwcBMYXiowP/h/XHgw=
=RfId
-----END PGP SIGNATURE-----

Re: NetAddr::IP's use of $& and $`

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

NetAddr::IP v4.007 removes everything that would cause PL_sawampersand 
to be set to true.

Daryl


Daryl C. W. O'Shea wrote:
> Hi Luis and Michael,
> 
> Would you be able to consider reworking NetAddr::IP to avoid the use of, 
> or loading of anything that uses, $& or $` so that the huge speed 
> penalty imposed by Perl when doing so can be avoided?
> 
> NetAddr::IP is used by Mail::SPF which is used by Mail::SpamAssassin. 
> Apache SpamAssassin needs to avoid the speed penalty imposed by $& and 
> $` at all costs.
> 
> Please see SpamAssassin bug 5312 for some background on this:
> http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5312
> 
> Thanks!
> 
> Regards,
> 
> Daryl C. W. O'Shea
> Apache SpamAssassin PMC Member