You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2013/12/01 21:35:18 UTC
Re: Review Request 15896: HIVE-5899 NPE during explain extended with
char/varchar columns
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15896/#review29570
-----------------------------------------------------------
+1 LGTM.
- Prasanth_J
On Nov. 28, 2013, 12:53 a.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15896/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2013, 12:53 a.m.)
>
>
> Review request for hive, Prasanth_J and Harish Butani.
>
>
> Bugs: HIVE-5899
> https://issues.apache.org/jira/browse/HIVE-5899
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Couple areas in the stats logic where it fetches the correct stats type based on the type string, which needed to be updated for char/varchar.
>
>
> Diffs
> -----
>
> data/files/alltypes.txt d86a7bc
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4f158bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 4658049
> ql/src/test/queries/clientpositive/annotate_stats_select.q 93492f5
> ql/src/test/results/clientpositive/annotate_stats_select.q.out 9cdfa74
>
> Diff: https://reviews.apache.org/r/15896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>