You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2015/12/15 19:59:40 UTC
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** open
**Milestone:** unreleased
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 06:59 PM UTC
**Owner:** nobody
We should switch our jslint tests to use npm-based tool instead of java. This will be more fitting with the es6 validation in [#8035].
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: open --> in-progress
- **assigned_to**: Dave Brondsema
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Wed Jan 13, 2016 03:09 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
I added broccoli-timepiece to the locally installed node packages and merged.
Great job with this one :)
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 18, 2016 07:35 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **Reviewer**: Heith Seewald
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Fri Jan 15, 2016 06:48 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
- **Comment**:
Cleaned that up, as well as a broccoli global package :)
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 18, 2016 06:16 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> in-progress
- **Comment**:
As discussed: we should be able to use a local version of some dependencies through use of node_modules/.bin
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 18, 2016 03:55 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: sf-current, sf-2 --> sf-2
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 18, 2016 08:33 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
- **Comment**:
db/8039
* make sure you install the new npm packages, as noted in the installation docs. AFAIK they have to be global and can't be specified in `package.js` because local packages won't add `eslint` to the `PATH`
* `allura.tests.functional.test_static:TestStatic.test_static_controller` is the only test that exercises JS validation by default
* at the bottom of `Allura/test.ini` you can set `validate_inlinejs` to true and then all functional tests will do more validation. There are many failures though.
* Note that when errors are captured and printed to the terminal, unicode comes through like `\u2716`. This is a limitation in nose, but for our Jenkins runs that use xunit xml files, the unicode will come through correctly there.
* we have no tests that cover .js files
[#8035] will need to modify `.eslintrc` and/or set up 2 different files. After that gets sorted out, we probably should make a ticket to enable JS validation by default and fix all the issues with .js files and inline script.
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Wed Jan 13, 2016 09:36 PM UTC
**Owner:** Dave Brondsema
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8039 Change jslint to use an npm tool instead of java
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: --> sf-current, sf-2
- Description has changed:
Diff:
~~~~
--- old
+++ new
@@ -1,4 +1,4 @@
-We should switch our jslint tests to use npm-based tool instead of java. This will be more fitting with the es6 validation in [#8035].
+We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
~~~~
---
** [tickets:#8039] Change jslint to use an npm tool instead of java**
**Status:** open
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Dec 15, 2015 06:59 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 06:59 PM UTC
**Owner:** nobody
We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works.
It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this:
Setting up ca-certificates-java (20130815ubuntu1) ...
Which is issue https://github.com/docker/docker/issues/18180
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.