[GitHub] [geode] PurelyApplied commented on pull request #3038: GEODE-6237: Opt into publication rather than opting out.

["PurelyApplied (GitHub)" <gi...@apache.org>]

That was left in the root `build.gradle` because that's where it had effectively been before.

Old style: publication was shoved into a `subprojects {` configuration, and `askpass` was outside that configuration, implicitly applied to the root project that called the `apply from: 'publish.gradle'`.

New style: publication is explicitly requested in the relevant subprojects via their own `apply from: 'publish.gradle'`.  The `askpass` logic which had been applied at root is now explicitly owned by the root's `build.gradle`.

To my eye, that logic is just a sanity check that gets run once the graph is ready.  That seems like a thing to be owned by root.

[ Full content available at: https://github.com/apache/geode/pull/3038 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org