You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/24 03:01:28 UTC

[GitHub] HyukjinKwon commented on a change in pull request #23257: [SPARK-26310][SQL] Verify applicability of JSON options

HyukjinKwon commented on a change in pull request #23257: [SPARK-26310][SQL] Verify applicability of JSON options
URL: https://github.com/apache/spark/pull/23257#discussion_r243783335
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
 ##########
 @@ -172,3 +189,34 @@ private[sql] object JSONOptionsInRead {
     Charset.forName("UTF-32")
   )
 }
+
+private[sql] class JSONOptionsInWrite(
 
 Review comment:
   we don't also need `private[sql]` since we're already in a private package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org