You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2006/10/31 10:39:17 UTC
[jira] Commented: (DERBY-2005) convert jdbcapi/Stream.java to Junit
[ http://issues.apache.org/jira/browse/DERBY-2005?page=comments#action_12445855 ]
Kristian Waagan commented on DERBY-2005:
----------------------------------------
Hi Fernanda,
The patch looks good as it is. I have a few questions/suggestions you could consider:
1) Could the test-methods be declared to throw IOException and SQLException instead of Exception?
2) As far as I can see, the TestDataStream/-Reader does not have any special functionality. To reduce the amount of code in the test class, could you instead use the existing stream/reader in 'functionTests.util.streams'?
3) Very much a nit, feel free to ignore, a space is missing in front of the starting curly brace on lines 53 and 176 (in the diff).
I ran the test individually and as part of jdbciapi/_Suite, both from classes and jars.
For some reason (not related to this test I think), the security manager denied access to read the property 'user.dir' on the machine I tested on (Gentoo Linux, AMD64, Java 1.5.0_08-b03 and Java SE 6 b103). I had to add the permission to the policy file. Has anyone else seen this?
Good work on the test, I think it can be committed as soon as the patch available flag is set.
> convert jdbcapi/Stream.java to Junit
> ------------------------------------
>
> Key: DERBY-2005
> URL: http://issues.apache.org/jira/browse/DERBY-2005
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Fernanda Pizzorno
> Assigned To: Fernanda Pizzorno
> Attachments: derby-2005.diff, derby-2005.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira