You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2019/11/05 22:09:23 UTC
Review Request 71723: RANGER-2637: RangerTags loading issue when
Ranger admin service is not available
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71723/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2637:
https://issues.apache.org/jira/browse/RANGER-2637:
Repository: ranger
Description
-------
RANGER-2637: RangerTags loading issue when Ranger admin service is not available
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 4caed81
Diff: https://reviews.apache.org/r/71723/diff/1/
Testing
-------
- Testing done in Local VM
- Shutdown ranger and check that Ranger Plugins for the services gets the tag from the cache file.
Thanks,
Ramesh Mani
Re: Review Request 71723: RANGER-2637: RangerTags loading issue when
Ranger admin service is not available
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71723/#review218517
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java
Lines 62 (patched)
<https://reviews.apache.org/r/71723/#comment306258>
Consider replacing #62, #63 with:
LOG.error("Tag-retriever failed to get tags from Ranger Admin. Will continue to use cached tags", e);
- Madhan Neethiraj
On Nov. 5, 2019, 10:09 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71723/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2019, 10:09 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2637:
> https://issues.apache.org/jira/browse/RANGER-2637:
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2637: RangerTags loading issue when Ranger admin service is not available
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 4caed81
>
>
> Diff: https://reviews.apache.org/r/71723/diff/1/
>
>
> Testing
> -------
>
> - Testing done in Local VM
> - Shutdown ranger and check that Ranger Plugins for the services gets the tag from the cache file.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 71723: RANGER-2637: RangerTags loading issue when
Ranger admin service is not available
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71723/#review218516
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 5, 2019, 10:09 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71723/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2019, 10:09 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2637:
> https://issues.apache.org/jira/browse/RANGER-2637:
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2637: RangerTags loading issue when Ranger admin service is not available
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 4caed81
>
>
> Diff: https://reviews.apache.org/r/71723/diff/1/
>
>
> Testing
> -------
>
> - Testing done in Local VM
> - Shutdown ranger and check that Ranger Plugins for the services gets the tag from the cache file.
>
>
> Thanks,
>
> Ramesh Mani
>
>