You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/09/06 08:20:19 UTC
Review Request 62113: Fixed compilation issue on Mac OS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
Repository: mesos
Description
-------
Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
tests to a test file that compiles on non-linux machines. This change
demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
Diffs
-----
src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
Diff: https://reviews.apache.org/r/62113/diff/1/
Testing
-------
make check on Mac OS
Thanks,
Alexander Rukletsov
Re: Review Request 62113: Fixed compilation issue on Mac OS.
Posted by Jie Yu <yu...@gmail.com>.
> On Sept. 6, 2017, 8:32 a.m., Jan Schlicht wrote:
> > src/tests/CMakeLists.txt
> > Lines 224 (patched)
> > <https://reviews.apache.org/r/62113/diff/1/?file=1816139#file1816139line225>
> >
> > See above.
sorry guys, will fix this.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184635
-----------------------------------------------------------
On Sept. 6, 2017, 8:20 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 8:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
>
>
> Diff: https://reviews.apache.org/r/62113/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62113: Fixed compilation issue on Mac OS.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184635
-----------------------------------------------------------
src/Makefile.am
Lines 2519 (patched)
<https://reviews.apache.org/r/62113/#comment260816>
The `volume/sandbox_path` isolator is built on all posix targets. Hence we have to run these tests not only on Linux.
src/tests/CMakeLists.txt
Lines 224 (patched)
<https://reviews.apache.org/r/62113/#comment260817>
See above.
- Jan Schlicht
On Sept. 6, 2017, 10:20 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 10:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
>
>
> Diff: https://reviews.apache.org/r/62113/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62113: Fixed compilation issue on Mac OS.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184722
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Sept. 6, 2017, 1:20 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 1:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
>
>
> Diff: https://reviews.apache.org/r/62113/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62113: Fixed compilation issue on Mac OS.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184645
-----------------------------------------------------------
FAIL: Mesos tests failed to run
Reviews applied: [62113]
Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62113/logs
- Mesos Reviewbot Windows
On Sept. 6, 2017, 8:20 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 8:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
>
>
> Diff: https://reviews.apache.org/r/62113/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62113: Fixed compilation issue on Mac OS.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184685
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62113]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 6, 2017, 8:20 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 8:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
>
>
> Diff: https://reviews.apache.org/r/62113/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS
>
>
> Thanks,
>
> Alexander Rukletsov
>
>