You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/20 23:43:38 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #5320: Support CentOS 8 RPMs
zrhoffman opened a new pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #5319<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
- Adds the option to build for either CentOS 7 or CentOS 8. CentOS 7 is the default, except for CDN in a Box, which uses CentOS 8 RPMs by default.
- Upgrades the builder Docker images to CentOS 8, although they can still be built for CentOS 7.
This PR builds off of @hbeatty's CentOS 8 progress from #5137.
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- CDN in a Box
- Documentation
- Build system
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
1. Check that Traffic Control works with RPMs built on and targeting CentOS 7
```shell script
export RHEL_VERSION=7
make build-builders -j6
docker-compose build --parallel
docker-compose up
```
2. Check that Traffic Control works with RPMs built on and targeting CentOS 7
```shell script
export RHEL_VERSION=8
make build-builders -j6
docker-compose build --parallel
docker-compose up
```
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] Existing tests are sufficient, no additional tests are unnecessary
- [x] This PR includes documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320#discussion_r533630055
##########
File path: infrastructure/cdn-in-a-box/Makefile
##########
@@ -79,6 +93,16 @@ native: all
endif
endif
+ifneq ($(filter pull-builders,$(MAKECMDGOALS)),)
+PKG_FLAGS += -p
+ifneq ($(MAKECMDGOALS),pull-builders)
+MAKECMDGOALS := $(filter-out pull-builders,$(MAKECMDGOALS))
+pull-builders: $(MAKECMDGOALS)
+else
+pull-builders: all
+endif
+endif
+
#.PHONY: native
Review comment:
No, I'm talking about `#.PHONY: native`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320#discussion_r533640892
##########
File path: infrastructure/cdn-in-a-box/Makefile
##########
@@ -79,6 +93,16 @@ native: all
endif
endif
+ifneq ($(filter pull-builders,$(MAKECMDGOALS)),)
+PKG_FLAGS += -p
+ifneq ($(MAKECMDGOALS),pull-builders)
+MAKECMDGOALS := $(filter-out pull-builders,$(MAKECMDGOALS))
+pull-builders: $(MAKECMDGOALS)
+else
+pull-builders: all
+endif
+endif
+
#.PHONY: native
Review comment:
Gotcha, removed in 899e3f1cde
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320#issuecomment-736220482
Rebased to fix merge conflicts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320#discussion_r533066499
##########
File path: infrastructure/cdn-in-a-box/Makefile
##########
@@ -79,6 +93,16 @@ native: all
endif
endif
+ifneq ($(filter pull-builders,$(MAKECMDGOALS)),)
+PKG_FLAGS += -p
+ifneq ($(MAKECMDGOALS),pull-builders)
+MAKECMDGOALS := $(filter-out pull-builders,$(MAKECMDGOALS))
+pull-builders: $(MAKECMDGOALS)
+else
+pull-builders: all
+endif
+endif
+
#.PHONY: native
Review comment:
This is the `pull-builders` target, the other one is the `build-builders` target.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5320: Support CentOS 8 RPMs
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5320:
URL: https://github.com/apache/trafficcontrol/pull/5320#discussion_r532947308
##########
File path: infrastructure/cdn-in-a-box/Makefile
##########
@@ -79,6 +93,16 @@ native: all
endif
endif
+ifneq ($(filter pull-builders,$(MAKECMDGOALS)),)
+PKG_FLAGS += -p
+ifneq ($(MAKECMDGOALS),pull-builders)
+MAKECMDGOALS := $(filter-out pull-builders,$(MAKECMDGOALS))
+pull-builders: $(MAKECMDGOALS)
+else
+pull-builders: all
+endif
+endif
+
#.PHONY: native
Review comment:
Since you did this above you can get rid of this now, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org