You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/04/05 05:22:29 UTC

Re: [PR] perf(metadata table) Metadata table archival should proceed until earliest commit to retain on data table [hudi]

yihua commented on code in PR #18215:
URL: https://github.com/apache/hudi/pull/18215#discussion_r3036428971


##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -428,6 +428,21 @@ public HoodieTestTable addClean(String instantTime, HoodieCleanerPlan cleanerPla
     return addClean(instantTime, Option.empty(), cleanerPlan, metadata, false, false);
   }
 
+  public HoodieTestTable addIncrementalClean(String instantTime, String earliestCommitToRetain) throws IOException {

Review Comment:
   🤖 nit: For these complex objects like `HoodieCleanerPlan` and `HoodieCleanStat` with many parameters, consider using a builder pattern if they are created frequently with varying attributes. It can improve readability by explicitly naming the parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org