You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by Craig L Russell <Cr...@Sun.COM> on 2007/12/27 00:19:02 UTC

Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Hi Matthew,

I don't think these checkins match the log comment. Looks like all  
the checkin did was to mis-order the java.lang.reflect imports and  
remove the white space between blocks of imports.

Craig

On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:

> Author: madams
> Date: Wed Dec 26 14:43:43 2007
> New Revision: 606964
>
> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
> Log:
> Readded missing JDOHelper import.
>
> Modified:
>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java
>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java
>
> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java
> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
> java/javax/jdo/spi/StateInterrogationTest.java? 
> rev=606964&r1=606963&r2=606964&view=diff
> ====================================================================== 
> ========
> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java (original)
> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
> @@ -17,14 +17,12 @@
>
>  package javax.jdo.spi;
>
> -import java.lang.reflect.InvocationHandler;
> -import java.lang.reflect.Proxy;
> -
>  import javax.jdo.JDOHelper;
>  import javax.jdo.PersistenceManager;
> -
>  import javax.jdo.util.AbstractTest;
>  import javax.jdo.util.BatchTestRunner;
> +import java.lang.reflect.InvocationHandler;
> +import java.lang.reflect.Proxy;
>
>  /**
>   * This class tests the StateInterrogation interface. The test is in
>
> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java
> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/javax/ 
> jdo/spi/StateInterrogationTest.java? 
> rev=606964&r1=606963&r2=606964&view=diff
> ====================================================================== 
> ========
> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java (original)
> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
> @@ -17,14 +17,12 @@
>
>  package javax.jdo.spi;
>
> -import java.lang.reflect.InvocationHandler;
> -import java.lang.reflect.Proxy;
> -
>  import javax.jdo.JDOHelper;
>  import javax.jdo.PersistenceManager;
> -
>  import javax.jdo.util.AbstractTest;
>  import javax.jdo.util.BatchTestRunner;
> +import java.lang.reflect.InvocationHandler;
> +import java.lang.reflect.Proxy;
>
>  /**
>   * This class tests the StateInterrogation interface. The test is in
>
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Matthew,

I think the changes should be reverted.

Craig

On Dec 26, 2007, at 3:49 PM, Matthew Adams wrote:

> Sho'nuff, the prior version was correct.  You want me to revert to  
> the prior version or leave it alone?  I'm really surprised that  
> happened...
>
> On Dec 26, 2007, at 3:24 PM, Matthew Adams wrote:
>
>> Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
>> revert, but I was getting missing symbol JDOHelper information  
>> during my build due to the missing import, and it really was  
>> missing...I'll look at it.
>>
>> On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:
>>
>>> Hi Matthew,
>>>
>>> I don't think these checkins match the log comment. Looks like  
>>> all the checkin did was to mis-order the java.lang.reflect  
>>> imports and remove the white space between blocks of imports.
>>>
>>> Craig
>>>
>>> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>>>
>>>> Author: madams
>>>> Date: Wed Dec 26 14:43:43 2007
>>>> New Revision: 606964
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>>>> Log:
>>>> Readded missing JDOHelper import.
>>>>
>>>> Modified:
>>>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>>
>>>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>>>> java/javax/jdo/spi/StateInterrogationTest.java? 
>>>> rev=606964&r1=606963&r2=606964&view=diff
>>>> =================================================================== 
>>>> ===========
>>>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java (original)
>>>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>>> @@ -17,14 +17,12 @@
>>>>
>>>>  package javax.jdo.spi;
>>>>
>>>> -import java.lang.reflect.InvocationHandler;
>>>> -import java.lang.reflect.Proxy;
>>>> -
>>>>  import javax.jdo.JDOHelper;
>>>>  import javax.jdo.PersistenceManager;
>>>> -
>>>>  import javax.jdo.util.AbstractTest;
>>>>  import javax.jdo.util.BatchTestRunner;
>>>> +import java.lang.reflect.InvocationHandler;
>>>> +import java.lang.reflect.Proxy;
>>>>
>>>>  /**
>>>>   * This class tests the StateInterrogation interface. The test  
>>>> is in
>>>>
>>>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>>>> javax/jdo/spi/StateInterrogationTest.java? 
>>>> rev=606964&r1=606963&r2=606964&view=diff
>>>> =================================================================== 
>>>> ===========
>>>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java (original)
>>>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>>> @@ -17,14 +17,12 @@
>>>>
>>>>  package javax.jdo.spi;
>>>>
>>>> -import java.lang.reflect.InvocationHandler;
>>>> -import java.lang.reflect.Proxy;
>>>> -
>>>>  import javax.jdo.JDOHelper;
>>>>  import javax.jdo.PersistenceManager;
>>>> -
>>>>  import javax.jdo.util.AbstractTest;
>>>>  import javax.jdo.util.BatchTestRunner;
>>>> +import java.lang.reflect.InvocationHandler;
>>>> +import java.lang.reflect.Proxy;
>>>>
>>>>  /**
>>>>   * This class tests the StateInterrogation interface. The test  
>>>> is in
>>>>
>>>>
>>>
>>> Craig Russell
>>> Architect, Sun Java Enterprise System http://java.sun.com/ 
>>> products/jdo
>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>
>> Matthew Adams
>> matthew@matthewadams.org
>> http://blog.matthewadams.org
>>
>
> Matthew Adams
> matthew@matthewadams.org
> http://blog.matthewadams.org
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Matthew,

I think the changes should be reverted.

Craig

On Dec 26, 2007, at 3:49 PM, Matthew Adams wrote:

> Sho'nuff, the prior version was correct.  You want me to revert to  
> the prior version or leave it alone?  I'm really surprised that  
> happened...
>
> On Dec 26, 2007, at 3:24 PM, Matthew Adams wrote:
>
>> Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
>> revert, but I was getting missing symbol JDOHelper information  
>> during my build due to the missing import, and it really was  
>> missing...I'll look at it.
>>
>> On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:
>>
>>> Hi Matthew,
>>>
>>> I don't think these checkins match the log comment. Looks like  
>>> all the checkin did was to mis-order the java.lang.reflect  
>>> imports and remove the white space between blocks of imports.
>>>
>>> Craig
>>>
>>> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>>>
>>>> Author: madams
>>>> Date: Wed Dec 26 14:43:43 2007
>>>> New Revision: 606964
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>>>> Log:
>>>> Readded missing JDOHelper import.
>>>>
>>>> Modified:
>>>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>>
>>>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>>>> java/javax/jdo/spi/StateInterrogationTest.java? 
>>>> rev=606964&r1=606963&r2=606964&view=diff
>>>> =================================================================== 
>>>> ===========
>>>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java (original)
>>>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>>> @@ -17,14 +17,12 @@
>>>>
>>>>  package javax.jdo.spi;
>>>>
>>>> -import java.lang.reflect.InvocationHandler;
>>>> -import java.lang.reflect.Proxy;
>>>> -
>>>>  import javax.jdo.JDOHelper;
>>>>  import javax.jdo.PersistenceManager;
>>>> -
>>>>  import javax.jdo.util.AbstractTest;
>>>>  import javax.jdo.util.BatchTestRunner;
>>>> +import java.lang.reflect.InvocationHandler;
>>>> +import java.lang.reflect.Proxy;
>>>>
>>>>  /**
>>>>   * This class tests the StateInterrogation interface. The test  
>>>> is in
>>>>
>>>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java
>>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>>>> javax/jdo/spi/StateInterrogationTest.java? 
>>>> rev=606964&r1=606963&r2=606964&view=diff
>>>> =================================================================== 
>>>> ===========
>>>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java (original)
>>>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>>> @@ -17,14 +17,12 @@
>>>>
>>>>  package javax.jdo.spi;
>>>>
>>>> -import java.lang.reflect.InvocationHandler;
>>>> -import java.lang.reflect.Proxy;
>>>> -
>>>>  import javax.jdo.JDOHelper;
>>>>  import javax.jdo.PersistenceManager;
>>>> -
>>>>  import javax.jdo.util.AbstractTest;
>>>>  import javax.jdo.util.BatchTestRunner;
>>>> +import java.lang.reflect.InvocationHandler;
>>>> +import java.lang.reflect.Proxy;
>>>>
>>>>  /**
>>>>   * This class tests the StateInterrogation interface. The test  
>>>> is in
>>>>
>>>>
>>>
>>> Craig Russell
>>> Architect, Sun Java Enterprise System http://java.sun.com/ 
>>> products/jdo
>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>
>> Matthew Adams
>> matthew@matthewadams.org
>> http://blog.matthewadams.org
>>
>
> Matthew Adams
> matthew@matthewadams.org
> http://blog.matthewadams.org
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Matthew Adams <ma...@matthewadams.org>.
Sho'nuff, the prior version was correct.  You want me to revert to  
the prior version or leave it alone?  I'm really surprised that  
happened...

On Dec 26, 2007, at 3:24 PM, Matthew Adams wrote:

> Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
> revert, but I was getting missing symbol JDOHelper information  
> during my build due to the missing import, and it really was  
> missing...I'll look at it.
>
> On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:
>
>> Hi Matthew,
>>
>> I don't think these checkins match the log comment. Looks like all  
>> the checkin did was to mis-order the java.lang.reflect imports and  
>> remove the white space between blocks of imports.
>>
>> Craig
>>
>> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>>
>>> Author: madams
>>> Date: Wed Dec 26 14:43:43 2007
>>> New Revision: 606964
>>>
>>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>>> Log:
>>> Readded missing JDOHelper import.
>>>
>>> Modified:
>>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>>
>>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>>> java/javax/jdo/spi/StateInterrogationTest.java? 
>>> rev=606964&r1=606963&r2=606964&view=diff
>>> ==================================================================== 
>>> ==========
>>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java (original)
>>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>> @@ -17,14 +17,12 @@
>>>
>>>  package javax.jdo.spi;
>>>
>>> -import java.lang.reflect.InvocationHandler;
>>> -import java.lang.reflect.Proxy;
>>> -
>>>  import javax.jdo.JDOHelper;
>>>  import javax.jdo.PersistenceManager;
>>> -
>>>  import javax.jdo.util.AbstractTest;
>>>  import javax.jdo.util.BatchTestRunner;
>>> +import java.lang.reflect.InvocationHandler;
>>> +import java.lang.reflect.Proxy;
>>>
>>>  /**
>>>   * This class tests the StateInterrogation interface. The test  
>>> is in
>>>
>>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>>> javax/jdo/spi/StateInterrogationTest.java? 
>>> rev=606964&r1=606963&r2=606964&view=diff
>>> ==================================================================== 
>>> ==========
>>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java (original)
>>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>> @@ -17,14 +17,12 @@
>>>
>>>  package javax.jdo.spi;
>>>
>>> -import java.lang.reflect.InvocationHandler;
>>> -import java.lang.reflect.Proxy;
>>> -
>>>  import javax.jdo.JDOHelper;
>>>  import javax.jdo.PersistenceManager;
>>> -
>>>  import javax.jdo.util.AbstractTest;
>>>  import javax.jdo.util.BatchTestRunner;
>>> +import java.lang.reflect.InvocationHandler;
>>> +import java.lang.reflect.Proxy;
>>>
>>>  /**
>>>   * This class tests the StateInterrogation interface. The test  
>>> is in
>>>
>>>
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/ 
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
>
> Matthew Adams
> matthew@matthewadams.org
> http://blog.matthewadams.org
>

Matthew Adams
matthew@matthewadams.org
http://blog.matthewadams.org


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Matthew Adams <ma...@matthewadams.org>.
Sho'nuff, the prior version was correct.  You want me to revert to  
the prior version or leave it alone?  I'm really surprised that  
happened...

On Dec 26, 2007, at 3:24 PM, Matthew Adams wrote:

> Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
> revert, but I was getting missing symbol JDOHelper information  
> during my build due to the missing import, and it really was  
> missing...I'll look at it.
>
> On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:
>
>> Hi Matthew,
>>
>> I don't think these checkins match the log comment. Looks like all  
>> the checkin did was to mis-order the java.lang.reflect imports and  
>> remove the white space between blocks of imports.
>>
>> Craig
>>
>> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>>
>>> Author: madams
>>> Date: Wed Dec 26 14:43:43 2007
>>> New Revision: 606964
>>>
>>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>>> Log:
>>> Readded missing JDOHelper import.
>>>
>>> Modified:
>>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>>
>>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>>> java/javax/jdo/spi/StateInterrogationTest.java? 
>>> rev=606964&r1=606963&r2=606964&view=diff
>>> ==================================================================== 
>>> ==========
>>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java (original)
>>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>> @@ -17,14 +17,12 @@
>>>
>>>  package javax.jdo.spi;
>>>
>>> -import java.lang.reflect.InvocationHandler;
>>> -import java.lang.reflect.Proxy;
>>> -
>>>  import javax.jdo.JDOHelper;
>>>  import javax.jdo.PersistenceManager;
>>> -
>>>  import javax.jdo.util.AbstractTest;
>>>  import javax.jdo.util.BatchTestRunner;
>>> +import java.lang.reflect.InvocationHandler;
>>> +import java.lang.reflect.Proxy;
>>>
>>>  /**
>>>   * This class tests the StateInterrogation interface. The test  
>>> is in
>>>
>>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java
>>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>>> javax/jdo/spi/StateInterrogationTest.java? 
>>> rev=606964&r1=606963&r2=606964&view=diff
>>> ==================================================================== 
>>> ==========
>>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java (original)
>>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>>> @@ -17,14 +17,12 @@
>>>
>>>  package javax.jdo.spi;
>>>
>>> -import java.lang.reflect.InvocationHandler;
>>> -import java.lang.reflect.Proxy;
>>> -
>>>  import javax.jdo.JDOHelper;
>>>  import javax.jdo.PersistenceManager;
>>> -
>>>  import javax.jdo.util.AbstractTest;
>>>  import javax.jdo.util.BatchTestRunner;
>>> +import java.lang.reflect.InvocationHandler;
>>> +import java.lang.reflect.Proxy;
>>>
>>>  /**
>>>   * This class tests the StateInterrogation interface. The test  
>>> is in
>>>
>>>
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/ 
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
>
> Matthew Adams
> matthew@matthewadams.org
> http://blog.matthewadams.org
>

Matthew Adams
matthew@matthewadams.org
http://blog.matthewadams.org


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Matthew Adams <ma...@matthewadams.org>.
Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
revert, but I was getting missing symbol JDOHelper information during  
my build due to the missing import, and it really was missing...I'll  
look at it.

On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:

> Hi Matthew,
>
> I don't think these checkins match the log comment. Looks like all  
> the checkin did was to mis-order the java.lang.reflect imports and  
> remove the white space between blocks of imports.
>
> Craig
>
> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>
>> Author: madams
>> Date: Wed Dec 26 14:43:43 2007
>> New Revision: 606964
>>
>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>> Log:
>> Readded missing JDOHelper import.
>>
>> Modified:
>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>>
>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>> java/javax/jdo/spi/StateInterrogationTest.java? 
>> rev=606964&r1=606963&r2=606964&view=diff
>> ===================================================================== 
>> =========
>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java (original)
>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>> @@ -17,14 +17,12 @@
>>
>>  package javax.jdo.spi;
>>
>> -import java.lang.reflect.InvocationHandler;
>> -import java.lang.reflect.Proxy;
>> -
>>  import javax.jdo.JDOHelper;
>>  import javax.jdo.PersistenceManager;
>> -
>>  import javax.jdo.util.AbstractTest;
>>  import javax.jdo.util.BatchTestRunner;
>> +import java.lang.reflect.InvocationHandler;
>> +import java.lang.reflect.Proxy;
>>
>>  /**
>>   * This class tests the StateInterrogation interface. The test is in
>>
>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>> javax/jdo/spi/StateInterrogationTest.java? 
>> rev=606964&r1=606963&r2=606964&view=diff
>> ===================================================================== 
>> =========
>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java (original)
>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>> @@ -17,14 +17,12 @@
>>
>>  package javax.jdo.spi;
>>
>> -import java.lang.reflect.InvocationHandler;
>> -import java.lang.reflect.Proxy;
>> -
>>  import javax.jdo.JDOHelper;
>>  import javax.jdo.PersistenceManager;
>> -
>>  import javax.jdo.util.AbstractTest;
>>  import javax.jdo.util.BatchTestRunner;
>> +import java.lang.reflect.InvocationHandler;
>> +import java.lang.reflect.Proxy;
>>
>>  /**
>>   * This class tests the StateInterrogation interface. The test is in
>>
>>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>

Matthew Adams
matthew@matthewadams.org
http://blog.matthewadams.org


Re: svn commit: r606964 - in /db/jdo/trunk: api2-legacy/test/java/javax/jdo/spi/StateInterrogationTest.java api2/test/java/javax/jdo/spi/StateInterrogationTest.java

Posted by Matthew Adams <ma...@matthewadams.org>.
Huh?  Oh, crap.  It must be an artifact of my IDE!  Well, we can  
revert, but I was getting missing symbol JDOHelper information during  
my build due to the missing import, and it really was missing...I'll  
look at it.

On Dec 26, 2007, at 3:19 PM, Craig L Russell wrote:

> Hi Matthew,
>
> I don't think these checkins match the log comment. Looks like all  
> the checkin did was to mis-order the java.lang.reflect imports and  
> remove the white space between blocks of imports.
>
> Craig
>
> On Dec 26, 2007, at 2:43 PM, madams@apache.org wrote:
>
>> Author: madams
>> Date: Wed Dec 26 14:43:43 2007
>> New Revision: 606964
>>
>> URL: http://svn.apache.org/viewvc?rev=606964&view=rev
>> Log:
>> Readded missing JDOHelper import.
>>
>> Modified:
>>     db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>>     db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>>
>> Modified: db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2-legacy/test/ 
>> java/javax/jdo/spi/StateInterrogationTest.java? 
>> rev=606964&r1=606963&r2=606964&view=diff
>> ===================================================================== 
>> =========
>> --- db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java (original)
>> +++ db/jdo/trunk/api2-legacy/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>> @@ -17,14 +17,12 @@
>>
>>  package javax.jdo.spi;
>>
>> -import java.lang.reflect.InvocationHandler;
>> -import java.lang.reflect.Proxy;
>> -
>>  import javax.jdo.JDOHelper;
>>  import javax.jdo.PersistenceManager;
>> -
>>  import javax.jdo.util.AbstractTest;
>>  import javax.jdo.util.BatchTestRunner;
>> +import java.lang.reflect.InvocationHandler;
>> +import java.lang.reflect.Proxy;
>>
>>  /**
>>   * This class tests the StateInterrogation interface. The test is in
>>
>> Modified: db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java
>> URL: http://svn.apache.org/viewvc/db/jdo/trunk/api2/test/java/ 
>> javax/jdo/spi/StateInterrogationTest.java? 
>> rev=606964&r1=606963&r2=606964&view=diff
>> ===================================================================== 
>> =========
>> --- db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java (original)
>> +++ db/jdo/trunk/api2/test/java/javax/jdo/spi/ 
>> StateInterrogationTest.java Wed Dec 26 14:43:43 2007
>> @@ -17,14 +17,12 @@
>>
>>  package javax.jdo.spi;
>>
>> -import java.lang.reflect.InvocationHandler;
>> -import java.lang.reflect.Proxy;
>> -
>>  import javax.jdo.JDOHelper;
>>  import javax.jdo.PersistenceManager;
>> -
>>  import javax.jdo.util.AbstractTest;
>>  import javax.jdo.util.BatchTestRunner;
>> +import java.lang.reflect.InvocationHandler;
>> +import java.lang.reflect.Proxy;
>>
>>  /**
>>   * This class tests the StateInterrogation interface. The test is in
>>
>>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>

Matthew Adams
matthew@matthewadams.org
http://blog.matthewadams.org