You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/25 13:49:33 UTC
[GitHub] [kafka] cadonna opened a new pull request, #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
cadonna opened a new pull request, #12210:
URL: https://github.com/apache/kafka/pull/12210
Apache Kafka 3.2.0 was recently released. Now we need
to test upgrades and compatibility with 3.2 in core system tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12210:
URL: https://github.com/apache/kafka/pull/12210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12210:
URL: https://github.com/apache/kafka/pull/12210#discussion_r1061872501
##########
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py:
##########
@@ -73,6 +75,7 @@ def min_cluster_size(self):
@parametrize(broker_version=str(LATEST_2_8))
@parametrize(broker_version=str(LATEST_3_0))
@parametrize(broker_version=str(LATEST_3_1))
+ @parametrize(broker_version=str(LATEST_3_2))
def test_produce_consume(self, broker_version, metadata_quorum=quorum.zk):
Review Comment:
We also need to test client protocol compatibility with all the versions. I submitted KIP-896 recently to fix this in a holistic way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12210:
URL: https://github.com/apache/kafka/pull/12210#discussion_r884021170
##########
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py:
##########
@@ -73,6 +75,7 @@ def min_cluster_size(self):
@parametrize(broker_version=str(LATEST_2_8))
@parametrize(broker_version=str(LATEST_3_0))
@parametrize(broker_version=str(LATEST_3_1))
+ @parametrize(broker_version=str(LATEST_3_2))
def test_produce_consume(self, broker_version, metadata_quorum=quorum.zk):
Review Comment:
I wonder if it's useful to continue testing older versions that we have not touched in years. Could we draw the line at 2.4 for example? For older versions, the main thing that seems useful to continue testing is the upgrade/downgrade tests. We don't necessarily have to change this in this patch of course, I'm just curious to hear what people think. cc @ijuma
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -91,6 +94,9 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_2), to_message_format_version=None, compression_types=["none"])
Review Comment:
Shall we update downgrade_test as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
jsancio commented on code in PR #12210:
URL: https://github.com/apache/kafka/pull/12210#discussion_r1061836000
##########
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py:
##########
@@ -73,6 +75,7 @@ def min_cluster_size(self):
@parametrize(broker_version=str(LATEST_2_8))
@parametrize(broker_version=str(LATEST_3_0))
@parametrize(broker_version=str(LATEST_3_1))
+ @parametrize(broker_version=str(LATEST_3_2))
def test_produce_consume(self, broker_version, metadata_quorum=quorum.zk):
Review Comment:
@hachikuji I agree with you. Kafka's system test are getting longer and longer to run. Should we move this discussion the mailing list or Jira to get some agreement here? cc @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12210:
URL: https://github.com/apache/kafka/pull/12210#issuecomment-1145659280
Passing system test run: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-06-02--001.system-test-kafka-branch-builder--1654200227--cadonna--AK13930-add_32_upgrade_comp_tests-core--7818cb8df6/report.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12210:
URL: https://github.com/apache/kafka/pull/12210#issuecomment-1145660378
Build failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a diff in pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on code in PR #12210:
URL: https://github.com/apache/kafka/pull/12210#discussion_r886522832
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -91,6 +94,9 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_2), to_message_format_version=None, compression_types=["none"])
Review Comment:
I included also downgrade tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12210: KAFKA-13930: Add 3.2.0 to core upgrade and compatibility system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12210:
URL: https://github.com/apache/kafka/pull/12210#issuecomment-1144568953
@hachikuji Thanks for the review! I have already tried to trigger a system test run but there seems to be a environmental issue because I get authentication errors. Locally, the system tests run but they are many and they put quite some load on my laptop even if I filter by the updated tests in this PR. I will retry to run them today and follow up with the responsible folks if I will run into issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org