You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/08/21 00:14:11 UTC
[GitHub] [daffodil-vscode] github-actions[bot] opened a new pull request, #261: Update sbt-native-packager to 1.9.11
github-actions[bot] opened a new pull request, #261:
URL: https://github.com/apache/daffodil-vscode/pull/261
Updates [com.github.sbt:sbt-native-packager](https://github.com/sbt/sbt-native-packager) from 1.9.9 to 1.9.11.
[GitHub Release Notes](https://github.com/sbt/sbt-native-packager/releases/tag/v1.9.11) - [Changelog](https://github.com/sbt/sbt-native-packager/blob/master/CHANGELOG.md) - [Version Diff](https://github.com/sbt/sbt-native-packager/compare/v1.9.9...v1.9.11)
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/17235ca1e60ff61e35fe7b7cf51163a15ffc435d/docs/repo-specific-configuration.md) file.
Have a fantastic day writing Scala!
<details>
<summary>Ignore future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-native-packager" } ]
```
</details>
labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1378130342
That makes sense to me. Any `libraryDependencies` added to `project/*.sbt` are available in the root `build.sbt` file, and we really don't need sbt-json if we only need that one play-json dependency.
Though, I *think* the sbt convention is for `libraryDependencies` to be added in a `project/build.sbt` file, to differentiate between plugins and configuration.
I also just noticed that we parse the package.json file in two different ways in build.sbt. Once to get the `daffodilVersion` using the play-json library and one to get just `version` which uses a regex. We should change those so they are consistent (either both use regex and remove the play-json dep, or both use play-json). Fine to do that in a separate PR/issue if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377679663
@stevedlawrence @mbeckerle Since we have a bunch of these PR and @scholarsmate has approved most of the them, could I combine all them into a single PR with an update to make the bots only run once monthly? This would be so you won't see a bunch of merges into main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell closed pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell closed pull request #261: Update sbt-native-packager to 1.9.11
URL: https://github.com/apache/daffodil-vscode/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377884020
What's pulling in scala-test? Seems like something is out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1378092642
So we could use
```sbt
"com.typesafe.play" %% "play-json" % "2.9.3"
```
instead of `sbt-json`. Its license under ALv2 so it would be compatible and when I tested switching it in for `sbt-json` it worked fine. The only thing was I couldn't add it as a plugin to `project/plugins.sbt` I have to it this way inside of that file.
```sbt
libraryDependencies ++= Seq(
"com.typesafe.play" %% "play-json" % "2.9.3"
)
```
The reason for adding it to `project/plugins.sbt` like that is because the `build.sbt` imports that package to get the version from the `package.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1379028157
@stevedlawrence I see what you are saying, I will remove the json dependency and use regexp to find the daffodil version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1382087504
See #414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377809229
This one actually may not be able to be updated as it breaks the scala code because of conflicting dependency between this package and scalatest.
```sbt
java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over 1.0.5
[error] +- com.github.sbt:sbt-native-packager:1.9.11 (sbtVersion=1.0, scalaVersion=2.12) (depends on 2.1.0)
[error] +- org.scalatest:scalatest_2.12:3.0.1 (depends on 1.0.5)
[error]
[error]
[error] this can be overridden using libraryDependencySchemes or evictionErrorLevel
[error] at scala.sys.package$.error(package.scala:30)
[error] at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:89)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:133)
[error] at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:73)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:146)
[error] at scala.util.control.Exception$Catch.apply(Exception.scala:228)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:146)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:127)
[error] at sbt.util.Tracked$.$anonfun$inputChangedW$1(Tracked.scala:219)
[error] at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:160)
[error] at sbt.Classpaths$.$anonfun$updateTask0$1(Defaults.scala:3687)
[error] at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] at sbt.Execute.work(Execute.scala:291)
[error] at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] at java.lang.Thread.run(Thread.java:750)
[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over 1.0.5
[error] +- com.github.sbt:sbt-native-packager:1.9.11 (sbtVersion=1.0, scalaVersion=2.12) (depends on 2.1.0)
[error] +- org.scalatest:scalatest_2.12:3.0.1 (depends on 1.0.5)
```
@stevedlawrence @mbeckerle Should we not update it or add this to `project/plugins.sbt`
```sbt
dependencyOverrides ++= Seq(
"org.scala-lang.modules" %% "scala-xml" % "2.1.0"
)
```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377871271
@stevedlawrence That makes sense but `scalatest` is not a dependency/plugin we have listed. So it gets downloaded as a transitive dependency because adding
```sbt
"org.scalatest" %% "scalatest" % "3.2.14" % "test"
```
to either `build.sbt` or `project/plugins.sbt` it fails to find it. The only way I resolved it locally was doing the dependency override shown above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377696895
It's up to the community, but I don't personally care either way. As long as the PR gets two +1's and things like license requirements are verified it doesn't really matter how they get committed. However, if a new PR is created, it does not two +1's. I don't think +1's from other similar PRs count, especially since there might be subtle changes that weren't noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377700025
Yeah that makes sense, I agree that +1 wouldn't carry over into a new PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377892951
I am not sure because I ran `sbt dependencyTree` and don't see it popping up. The only way I could override it was by adding
```sbt
dependencyOverrides ++= Seq(
"org.scalatest" %% "scalatest" % "3.2.15" % Test
)
```
to `project/plugins.sbt`. So I am not sure if its just a default because adding it as plugin, libraryDependencies or to the dependencyOverrides in the comonSettings didn't fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1377819967
We had a similar issue with Daffodil. You likely just need to update scalatest and sbt-native-packager at the same time (assuming newer versions of scala-test have updated to the latest version of scala-xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #261: Update sbt-native-packager to 1.9.11
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #261:
URL: https://github.com/apache/daffodil-vscode/pull/261#issuecomment-1378018286
If you run `sbt "reload plugins" "dependencyTree"`, you can see the dependency tree of the plugins and where scalatest is getting pulled in.
And it looks like the issue is in the `sbt-json` plugin.
It looks like sbt-json incorrectly defines scalatest as a normal dependency and not a test dependency. And the plugin isn't even maintained anymore so I'm not sure it's going to get fixed. Do we even need that plugin? Or maybe there's an alternative available? We definitely don't need scalatest in the plugin so there might be an sbt configuration to exclude it completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org