You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2017/12/27 08:10:05 UTC

Review Request 64850: Fixing interface and file renaming issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64850/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle.


Bugs: AMBARI-22653
    https://issues.apache.org/jira/browse/AMBARI-22653


Repository: ambari


Description
-------

Patch https://reviews.apache.org/r/64607 contains two renamed interfaces:
DocumentIterator -> CloseableIterator
DocumentSource -> ItemWriterListener

but the files containing these interface definitions were not renamed on trunk git repo


Diffs
-----

  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java  
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java  


Diff: https://reviews.apache.org/r/64850/diff/1/


Testing
-------

maven build
unit and integration tests


Thanks,

Krisztian Kasa

Re: Review Request 64850: Fixing interface and file renaming issues

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64850/
-----------------------------------------------------------

(Updated Dec. 27, 2017, 10:20 a.m.)


Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle.


Bugs: AMBARI-22653
    https://issues.apache.org/jira/browse/AMBARI-22653


Repository: ambari


Description (updated)
-------

Patch https://reviews.apache.org/r/64607 contains two renamed interfaces:
DocumentIterator -> CloseableIterator
DocumentSource -> ItemWriterListener

but the files containing these interface definitions were not renamed on trunk git repo

Using java.util.ArrayList insted of com.google.common.collect.Lists.newArrayList()


Diffs (updated)
-----

  ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraManagerStories.java cf720ef0d0 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java 5fa29b0099 
  ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java 742777109e 


Diff: https://reviews.apache.org/r/64850/diff/2/

Changes: https://reviews.apache.org/r/64850/diff/1-2/


Testing
-------

maven build
unit and integration tests


Thanks,

Krisztian Kasa

Re: Review Request 64850: Fixing interface and file renaming issues

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64850/#review194527
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Dec. 27, 2017, 8:10 a.m., Krisztian Kasa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64850/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2017, 8:10 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22653
>     https://issues.apache.org/jira/browse/AMBARI-22653
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch https://reviews.apache.org/r/64607 contains two renamed interfaces:
> DocumentIterator -> CloseableIterator
> DocumentSource -> ItemWriterListener
> 
> but the files containing these interface definitions were not renamed on trunk git repo
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java  
>   ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java  
> 
> 
> Diff: https://reviews.apache.org/r/64850/diff/1/
> 
> 
> Testing
> -------
> 
> maven build
> unit and integration tests
> 
> 
> Thanks,
> 
> Krisztian Kasa
> 
>