You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2011/01/06 10:15:07 UTC

svn commit: r1055796 - in /maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin: announcement/AnnouncementMojo.java changes/IssueAdapter.java jira/JiraAdapter.java

Author: dennisl
Date: Thu Jan  6 09:15:06 2011
New Revision: 1055796

URL: http://svn.apache.org/viewvc?rev=1055796&view=rev
Log:
o Rename JiraAdapter to IssueAdapter, now that  it works with the generic Issue class.
o Move it to the changes package because it outputs changes models.

Added:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java   (contents, props changed)
      - copied, changed from r1055657, maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraAdapter.java
Removed:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraAdapter.java
Modified:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java

Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java?rev=1055796&r1=1055795&r2=1055796&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java Thu Jan  6 09:15:06 2011
@@ -29,10 +29,10 @@ import java.util.List;
 import java.util.Map;
 
 import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.changes.IssueAdapter;
 import org.apache.maven.plugin.changes.ChangesXML;
 import org.apache.maven.plugin.changes.ProjectUtils;
 import org.apache.maven.plugin.changes.ReleaseUtils;
-import org.apache.maven.plugin.jira.JiraAdapter;
 import org.apache.maven.plugin.jira.JiraXML;
 import org.apache.maven.plugins.changes.model.Release;
 import org.apache.maven.project.MavenProject;
@@ -636,7 +636,7 @@ public class AnnouncementMojo
 
                 List issues = jiraParser.getIssueList();
 
-                return JiraAdapter.getReleases( issues );
+                return IssueAdapter.getReleases( issues );
             }
             else
             {

Copied: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java (from r1055657, maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraAdapter.java)
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java?p2=maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java&p1=maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraAdapter.java&r1=1055657&r2=1055796&rev=1055796&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraAdapter.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java Thu Jan  6 09:15:06 2011
@@ -1,4 +1,4 @@
-package org.apache.maven.plugin.jira;
+package org.apache.maven.plugin.changes;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -30,20 +30,20 @@ import java.util.List;
 import java.util.Map;
 
 /**
- * An adapter that can adapt JIRA specific data models to the data model used
- * by a changes.xml file.
+ * An adapter that can adapt issue management system data models to the data model used
+ * in the changes.xml file.
  *
  * @author Dennis Lundberg
  * @version $Id$
  * @since 2.4
  */
-public class JiraAdapter
+public class IssueAdapter
 {
     /**
      * Adapt a <code>List</code> of <code>Issue</code>s to a
      * <code>List</code> of <code>Release</code>s.
      *
-     * @param issues The JIRA issues
+     * @param issues The issues
      * @return A list of releases
      */
     public static List getReleases( List issues )
@@ -99,8 +99,10 @@ public class JiraAdapter
     {
         Action action = new Action();
 
+        // @todo We need to add something like issue.getPresentationIdentifier() to be able to support other IMSes beside JIRA
         action.setIssue( issue.getKey() );
 
+        // @todo To support types for different IMSes we need some way to map these values to the ones used in a particular IMS
         String type = "";
         if ( issue.getType().equals( "Bug" ) )
         {

Propchange: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/IssueAdapter.java
------------------------------------------------------------------------------
    svn:keywords = Date Revision Author Id