You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/01 12:29:11 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1148: Move VERSION file to src folder

PragmaTwice commented on issue #1148:
URL: https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333696239

   Actually I have some doubt about this proposal. In my view, the `VERSION` file is not a source file, which seems not proper to be placed into the `src` directory.
   
   We can see the CI failed when someone try to move this file to `src` in #1149, whose reason is quite funny: there is a header named `version` in the C++ standard, and the move cause compiler to find wrong header and fail to compile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org