You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/10/23 09:30:07 UTC
[PR] Clarify how late placeholder replacement (@{...}) deals with [maven-surefire]
kwin opened a new pull request, #3208:
URL: https://github.com/apache/maven-surefire/pull/3208
unresolvable parameters
Also outline that this syntax is only necessary for property values which are modified, not for those which are exclusively set through other plugins due to how resolving works for plugin parameters (org.apache.maven.plugin.PluginParameterExpressionEvaluator)
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify how late placeholder replacement (@{...}) deals with [maven-surefire]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #3208:
URL: https://github.com/apache/maven-surefire/pull/3208#discussion_r2464576250
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -447,9 +447,15 @@ public abstract class AbstractSurefireMojo extends AbstractMojo implements Suref
* Arbitrary JVM options to set on the command line. Only effective for forked executions.
* <br>
* <br>
- * Since the Version 2.17 using an alternate syntax for {@code argLine}, <b>@{...}</b> allows late replacement
- * of properties when the plugin is executed, so properties that have been modified by other plugins will be picked
+ * Since version 2.17 using an alternate syntax for {@code argLine}, <code>@{...}</code> allows late replacement
Review Comment:
I think we can remove `since ....` it refers to very old one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify how late placeholder replacement (@{...}) deals with [maven-surefire]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #3208:
URL: https://github.com/apache/maven-surefire/pull/3208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org