You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/04/27 16:25:37 UTC
[GitHub] [lucene-solr] romseygeek opened a new pull request #1461: LUCENE-9348: Add a base grouping test for use with different GroupSelector implementations
romseygeek opened a new pull request #1461:
URL: https://github.com/apache/lucene-solr/pull/1461
The grouping module tests currently all try and test both grouping by term and
grouping by ValueSource. They are quite difficult to follow, however, and it is not
at all easy to add tests for a new grouping type. This commit adds a new
BaseGroupSelectorTestCase class which can be extended to test particular
GroupSelector implementations, and adds tests for TermGroupSelector and
ValueSourceGroupSelector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] romseygeek commented on pull request #1461: LUCENE-9348: Add a base grouping test for use with different GroupSelector implementations
Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #1461:
URL: https://github.com/apache/lucene-solr/pull/1461#issuecomment-620093446
cc @martijnvg @dsmiley
We should be able to remove `AllGroupHeadsCollectorTest`, `AllGroupsCollectorTest` and `GroupingSearchTest` once this is merged, and possibly `TestGrouping` as well. It should also make it much easier to add groupers based on Double/LongValuesSource, with the aim of moving the `ValueSourceGroupSelector` into Solr and deprecating ValueSource within lucene.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org