You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Nick White <nw...@palantir.com> on 2014/04/24 10:44:13 UTC

Review Request 20656: HIVE-6923: Use slf4j For Logging Everywhere

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20656/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

Hive uses a mixture of slf4j (backed by log4j) and commons-logging. I've attached a patch to tidy this up, by just using slf4j for all loggers. This means that applications using the JDBC driver can make Hive log through their own slf4j implementation consistently.


Diffs
-----

  beeline/pom.xml 7449430 
  beeline/src/java/org/apache/hive/beeline/util/QFileClient.java b62a883 
  cli/pom.xml 305b9b1 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 27b8504 
  cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 865848a 
  common/pom.xml b3d230d 
  common/src/java/org/apache/hadoop/hive/common/FileUtils.java c3a2cd4 
  common/src/java/org/apache/hadoop/hive/common/LogUtils.java 9118675 
  common/src/java/org/apache/hadoop/hive/common/ServerUtils.java f73dffb 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 46f9f42 
  common/src/java/org/apache/hive/common/util/HiveStringUtils.java c21c937 
  common/src/java/org/apache/hive/common/util/HiveVersionInfo.java de42e6c 
  common/src/java/org/apache/hive/common/util/ShutdownHookManager.java fd2f20a 
  contrib/pom.xml 43d1f95 
  contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java 1a54147 
  contrib/src/java/org/apache/hadoop/hive/contrib/serde2/RegexSerDe.java f44b4a5 
  contrib/src/java/org/apache/hadoop/hive/contrib/serde2/TypedBytesSerDe.java f79f821 
  contrib/src/java/org/apache/hadoop/hive/contrib/serde2/s3/S3LogDeserializer.java 69b618b 
  hbase-handler/pom.xml 7c3524c 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStatsAggregator.java 1b96232 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStatsPublisher.java 8266b33 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 704fcb9 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java e5ac9d3 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 6d383b5 
  hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java f1feb1a 
  hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatBaseOutputFormat.java 512328a 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java d49c70c 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CatchallExceptionMapper.java 4288f5d 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/DeleteDelegator.java 5610ced 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java 5b4fd9b 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/HcatDelegator.java cd9128e 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/LauncherDelegator.java 854aa99 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java 09c248e 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/PigDelegator.java 04e061d 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ProxyUserSupport.java ec5acb4 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java d47f97e 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java 6e75909 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/StatusDelegator.java c15da98 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSCleanup.java 1202ffe 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java fb46b58 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/JobState.java afca4ac 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/JobStateTracker.java da3ad20 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/LaunchMapper.java 100a504 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 4807e79 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java 73892cc 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/ZooKeeperCleanup.java 4f5e2d9 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/ZooKeeperStorage.java ecde598 
  hwi/pom.xml 031d030 
  hwi/src/java/org/apache/hadoop/hive/hwi/HWIContextListener.java eae4040 
  hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java 545f687 
  hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 0ad8f89 
  hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionManager.java 3d5aea9 
  itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomNonSettableStructObjectInspector1.java c09fd61 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 7fbb67e 
  itests/qtest/pom.xml e70da0f 
  itests/test-serde/src/main/java/org/apache/hadoop/hive/serde2/TestSerDe.java 23e67e3 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b192aaf 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 195a5a4 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/UDFFileLookup.java 61c7e0c 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSumList.java 55d7912 
  jdbc/pom.xml 016e01f 
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 3215178 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 4102d7a 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 86bc580 
  metastore/pom.xml 5f7b4ad 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 7c74e79 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 51464cf 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java dafc419 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 325aa8b 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreInit.java f674244 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java cee1637 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java d60cb1b 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStoreProxy.java 1cf09d4 
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 204c930 
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5410b45 
  metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java f731dab 
  metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerTask.java df82bce 
  metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java 7dc5f44 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyMetaStoreInitListener.java 00bbad7 
  metastore/src/test/org/apache/hadoop/hive/metastore/VerifyingObjectStore.java 7e46523 
  pom.xml a09b01d 
  ql/pom.xml 53d0b9e 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java e699c6b 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 332cadb 
  ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 6b31824 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java f834ad5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AutoProgressor.java d7323cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 99b062f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java aacf200 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java b429a58 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4310ab8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultBucketMatcher.java fccdc89 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java b0b0925 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java bb5f4f3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java ffc4c42 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 770d904 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b9a5d38 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java bd45df1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java c4c85fa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 24f1229 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 2981a3b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java c0f4cd7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 5b6dd6a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapredContext.java ce705c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java b10a7fa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java aa96d23 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 9caf79e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFPartition.java 01d31a7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7a7dc88 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SkewJoinHandler.java 3bf58f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 0169077 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java c5bbe68 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TopNHash.java 978a749 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java afd7bcf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java cc840be 
  ql/src/java/org/apache/hadoop/hive/ql/exec/errors/TaskLogProcessor.java 12433ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mapjoin/MapJoinMemoryExhaustionHandler.java 905e65e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 2f5f60c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapperContext.java 74bc2d2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java fa662c8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java a4585de 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HashTableLoader.java 5cf347b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 29fbb03 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java 79736ef 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/Throttle.java f582c39 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HashMapWrapper.java 61545b5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/RowContainer.java 3b0bc2a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java 47f9d21 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 380f21d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java 318ba8e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java ea771f3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java 7c2c2a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 9211d6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java 9c3284b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java b8552a3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/tools/InputMerger.java e5746c4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 4568496 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java 2466a3b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorReduceSinkOperator.java 661725e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java 997202f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 842994e 
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java f75b70e 
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryViewer.java 1b357de 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java 835caf1 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexResult.java 332ced8 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java c52624c 
  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 0af8d7d 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 11ddcae 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/HiveCompactIndexInputFormat.java 7cebe68 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 520590f 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputSplit.java 481deba 
  ql/src/java/org/apache/hadoop/hive/ql/io/CodecPool.java 9dfb6bf 
  ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java dc2fb96 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java f874d86 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 647a9a6 
  ql/src/java/org/apache/hadoop/hive/ql/io/NullRowsInputFormat.java fd60fed 
  ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java 3bc7e43 
  ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/MemoryManager.java 9af12de 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 180be2f 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java c4268c1 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java a34a6ce 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 7798a7c 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 7e9bed6 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java b87c673 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 2f155f6 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java e1a7a48 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/ParquetRecordWriterWrapper.java cd603c2 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java 5a6899c 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileMergeMapper.java ffd7597 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java 3e1ef0a 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java 4b58d92 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateMapper.java 257f186 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 9550001 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 093be45 
  ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java c4327fc 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java 282b284 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 7803169 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 9a6e336 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 96cba25 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 2850c7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 0b7b1a3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AvgPartitionSizeBasedBigTableSelectorForAutoSMJ.java 8719576 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketJoinProcCtx.java 911b1c8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 6f35b87 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 0798470 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 384342a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 978c18d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java d2aa220 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java 603a261 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java c16010f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java f1ef4ce 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java b4aeb14 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/PrunerUtils.java 108177e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java d966300 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java b0f4b47 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SetReducerParallelism.java b522963 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 7413d2b 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 54afbfe 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapJoinOptimizer.java 51f1b74 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 1d23449 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java 3595640 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/QueryPlanTreeTransformation.java aa02a40 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java cc94254 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java 11a6d07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java dee7d7e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java 1d8336f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/OpProcFactory.java 78b7ca8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/LBPartitionProcFactory.java 41d27fa 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPruner.java 33b6e86 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PartitionConditionRemover.java cbed375 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrOpProcFactory.java c2d49f6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 7f2bb60 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java e6be03f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java a115c67 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java 5c6751c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java d98b5c5 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 6bdf394 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 069f7ae 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java 74b595a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2484576 
  ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 56999de 
  ql/src/java/org/apache/hadoop/hive/ql/parse/FileSinkProcessor.java 9592992 
  ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 68a25e0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 042cb39 
  ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java 475c940 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java a8d1a68 
  ql/src/java/org/apache/hadoop/hive/ql/parse/InputSignature.java 213d446 
  ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 0ae07e3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 76f5a31 
  ql/src/java/org/apache/hadoop/hive/ql/parse/MetaDataExportListener.java a16c7dc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java f339651 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 52c39c0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java 84ecb0f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java a8b436e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBExpr.java e923bca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBMetaData.java 66faf1d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a7cec5d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java f142f3e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java d847a16 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java b569ed0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java b7738c5 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 9a947ec 
  ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java f292944 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java 5c3a582 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 98c511e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 76ddb1e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 19b553f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDesc.java 95f38b6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java c60f56f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java afb3648 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java 9112a77 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerInfo.java 6a3dd99 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java 4175d11 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 40298e1 
  ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java 5ed1e6c 
  ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java 8b8475b 
  ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java 83fadeb 
  ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java d343a3c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java e0d9c74 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 18a1b25 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 7bb5a88 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 16e9166 
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 7b5a7a5 
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java ef49801 
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java f59e60a 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 3216cf3 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java faa2387 
  ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java f636cff 
  ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java 606ccb3 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java 641bba2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java bc5e1e2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFE.java a042116 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPI.java 07288c1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java fd1f0e3 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRegExp.java 76e1d2e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 6e4bee0 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java c286619 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java abd54be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java 536c4a7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java 6dc424a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 7348478 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 17e9d76 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java 89bc1a7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java f1017be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCumeDist.java 18c8c8d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFDenseRank.java c1d43d8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEWAHBitmap.java e4b412e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFFirstValue.java 748ce55 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java f2e8e03 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java d265acc 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLastValue.java 138c152 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLead.java d7c18e5 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLeadLag.java 295cd2e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMax.java d6e9db4 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMin.java 3dc9900 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFNTile.java 18cde76 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentRank.java aab1922 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 56e76be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRank.java 5c8f1e0 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRowNumber.java 987da3d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 8508ffb 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 3545390 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 4a7caab 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java a0aeccf 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToChar.java 83e36a5 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java b857f6a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java 0336ecd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFParseUrlTuple.java dff9ba6 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java a199ec9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java 24159b8 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
  ql/src/test/org/apache/hadoop/hive/ql/exec/mapjoin/TestMapJoinMemoryExhaustionHandler.java 595ffa6 
  ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java 9d8009b 
  ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 41243fe 
  serde/pom.xml 6378b72 
  serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java 179f9b5 
  serde/src/java/org/apache/hadoop/hive/serde2/MetadataTypedColumnsetSerDe.java 8cc752f 
  serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 4b9a4f9 
  serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java d972321 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 55bfa2e 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java d848005 
  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java fcded96 
  serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 5870884 
  serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarStruct.java 157600e 
  serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java 6f344bb 
  serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java 1f4ccdd 
  serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java 67cb1e8 
  serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java 435d6c6 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java ae12f20 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyDate.java 7af2374 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyDouble.java 05ca4e9 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFloat.java 37676d1 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveChar.java ef469eb 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java 78cc381 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java bc8d41e 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyPrimitive.java 222b9bc 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 606208c 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java 8a1ea46 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 27895c5 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyListObjectInspector.java 9d66a78 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyMapObjectInspector.java ee870f5 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java 8a5386a 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java 792a9a2 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryDate.java d0c2504 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryMap.java 31ad78e 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 0324453 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java caf3517 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryTimestamp.java 98dd81c 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java c583ae2 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java 7d0d91c 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 64e651c 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java 077c371 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 5ccacf1 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java 7bbfd1f 
  serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java 61f770d 
  serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java 63f3287 
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java e5c9f18 
  service/pom.xml a97577b 
  service/src/java/org/apache/hadoop/hive/service/HiveServer.java 32729f2 
  service/src/java/org/apache/hive/service/AbstractService.java c2a2b2d 
  service/src/java/org/apache/hive/service/CompositeService.java 8979118 
  service/src/java/org/apache/hive/service/ServiceOperations.java 8946219 
  service/src/java/org/apache/hive/service/cli/CLIService.java 2b1e712 
  service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f708650 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java 3f36e2d 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java d6d0d27 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java cec3b04 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 26bda5a 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java a6ff6ce 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java e77f043 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b 
  service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java bbb2a42 
  shims/0.23/pom.xml 43738d3 
  shims/common-secure/pom.xml 86de522 
  shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java e205caa 
  shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java dc89de1 
  shims/common/pom.xml a6376f1 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 9e9a60d 

Diff: https://reviews.apache.org/r/20656/diff/


Testing
-------

Ran a clean Hive build (including tests) -Phadoop-1


Thanks,

Nick White