[GitHub] ctubbsii commented on a change in pull request #446: Expose negation to shell

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #446: Expose negation to shell
URL: https://github.com/apache/accumulo/pull/446#discussion_r184512808
 
 

 ##########
 File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java
 ##########
 @@ -106,7 +113,9 @@ public String description() {
   public Options getOptions() {
     final Options opts = super.getOptions();
     numThreadsOpt = new Option("nt", "num-threads", true, "number of threads to use");
+    negateOpt = new Option("v", "negate", false, "only include rows without search term");
 
 Review comment:
   `-v` is typically reserved for `--verbose`; I think it could be confusing to use `-v` for this option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services