You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/30 16:01:06 UTC

[GitHub] [helix] narendly commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator

narendly commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r838715869



##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -82,6 +84,10 @@
     // error exceeds this limitation
     DISABLED_INSTANCES,
 
+    VIEW_CLUSTER, // Set to "true" to indicate this is a view cluster
+    VIEW_CLUSTER_SOURCES, // Map field, key is the name of source cluster, value is
+    // ViewClusterSourceConfig JSON string
+    VIEW_CLUSTER_REFRESH_PERIOD, // In second

Review comment:
       Nit: I find that it's much clearer to just encode the unit in the enum. Should we just do `VIEW_CLUSTER_REFRESH_PERIOD_IN_SEC`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org