You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/06/08 21:45:42 UTC

[GitHub] [guacamole-server] mike-jumper commented on a diff in pull request #383: GUACAMOLE-1622: Added margins to ssh sessions.

mike-jumper commented on code in PR #383:
URL: https://github.com/apache/guacamole-server/pull/383#discussion_r892892734


##########
src/terminal/terminal/terminal.h:
##########
@@ -97,6 +97,16 @@
  */
 #define GUAC_TERMINAL_WHEEL_SCROLL_AMOUNT 3
 
+/**
+ * The size of margins between the console text and the border in pixels.
+ */
+#define GUAC_TERMINAL_MARGINS 16

Review Comment:
   This and `GUAC_TERMINAL_OFFSET` will need to be in some pixel-independent units to allow the margins to scale for different display resolutions. Not all screens will have the same DPI, and the terminal font rendering takes this into account.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org